Bug 87791 - Show an error in the pretty diff when an image lacks a checksum
Summary: Show an error in the pretty diff when an image lacks a checksum
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 16:17 PDT by Ojan Vafai
Modified: 2012-05-30 09:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2012-05-29 16:18 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-05-29 16:17:56 PDT 
Show an error in the pretty diff when an image lacks a checksum
Comment 1 Ojan Vafai 2012-05-29 16:18:24 PDT 
Created attachment 144639 [details]
Patch
Comment 2 Tony Chang 2012-05-29 17:03:31 PDT 
Comment on attachment 144639 [details]
Patch

Is this only for expected.png files?  What if someone is checking in a png, e.g., for the web inspector?
Comment 3 Dirk Pranke 2012-05-29 17:06:29 PDT 
(In reply to comment #2)
> (From update of attachment 144639 [details])
> Is this only for expected.png files?  What if someone is checking in a png, e.g., for the web inspector?

bah, good point.
Comment 4 WebKit Review Bot 2012-05-29 19:18:25 PDT 
Comment on attachment 144639 [details]
Patch

Clearing flags on attachment: 144639

Committed r118882: <http://trac.webkit.org/changeset/118882>
Comment 5 WebKit Review Bot 2012-05-29 19:18:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kent Tamura 2012-05-29 22:42:04 PDT 
It seems PrettyPatch warns whenever a patch adds (not updates) new images.
Comment 7 Ojan Vafai 2012-05-30 09:14:21 PDT 
(In reply to comment #6)
> It seems PrettyPatch warns whenever a patch adds (not updates) new images.

Not sure I understand. Can you point me at a patch/bug where it's doing the wrong thing?