Bug 87788 - [chromium] Migrate to WebTransformationMatrix
Summary: [chromium] Migrate to WebTransformationMatrix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on: 87315 87510
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-29 15:38 PDT by Shawn Singh
Modified: 2012-05-31 17:24 PDT (History)
8 users (show)

See Also:


Attachments
for backup, not for review yet (204.51 KB, patch)
2012-05-31 16:35 PDT, Shawn Singh
no flags Details | Formatted Diff | Diff
Same patch with changelogs (219.06 KB, patch)
2012-05-31 17:08 PDT, Shawn Singh
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2012-05-29 15:38:51 PDT
This patch will substitute all instances of WebCore::TransformationMatrix with WebKit::WebTransformationMatrix in the chromium compositor.  The change should be completely transparent and incur minimal overhead (specifically, all functions incur one additional trivial wrapper function call on the stack), which will be OK for production, but will that overhead will probably be temporary anyway.

This migration is covered by unit tests and layout tests, and should have no change in behavior.
Comment 1 Shawn Singh 2012-05-31 16:35:52 PDT
Created attachment 145175 [details]
for backup, not for review yet

This version passes all unit tests, but still need to test it a lot more and add changelogs
Comment 2 Shawn Singh 2012-05-31 17:08:20 PDT
Created attachment 145177 [details]
Same patch with changelogs

This patch is ready for review.  Tested on all unit tests, layout tests, and manually, on mac.  This patch does the following: (a) replaced all instances of WebCore::TransformationMatrix with WebKit::WebTransformationMatrix, (b) handled the namespace and other minor fallouts to get things to compile and be clean (c) a few minor cleanups while making things compile (d) adds a new constructor (and unit test) to WebTransformationMatrix
Comment 3 WebKit Review Bot 2012-05-31 17:11:44 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2012-05-31 17:16:10 PDT
Comment on attachment 145177 [details]
Same patch with changelogs

R=me
Comment 5 James Robinson 2012-05-31 17:24:47 PDT
Committed r119178: <http://trac.webkit.org/changeset/119178>