WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87762
TextFieldDecorationElement should respect style attribute
https://bugs.webkit.org/show_bug.cgi?id=87762
Summary
TextFieldDecorationElement should respect style attribute
Garrett Casto
Reported
2012-05-29 11:44:52 PDT
Currently changing the style of a TextFieldDecorationElement does not result in the element rendering any differently. This is because customStyleForRenderer() does not take into account the current styling of the element.
Attachments
Patch
(1.76 KB, patch)
2012-05-30 13:20 PDT
,
Garrett Casto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Garrett Casto
Comment 1
2012-05-29 17:54:49 PDT
Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.
Kent Tamura
Comment 2
2012-05-29 18:03:49 PDT
(In reply to
comment #1
)
> Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.
Would you take this please? I think the customStyleForRenderr() should be: - RefPtr<RenderStyle> style = RenderStyle::create(); + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);
Garrett Casto
Comment 3
2012-05-29 18:05:31 PDT
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. > > Would you take this please? > > I think the customStyleForRenderr() should be: > > - RefPtr<RenderStyle> style = RenderStyle::create(); > + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);
Got it. I'll see if this works.
Kent Tamura
Comment 4
2012-05-29 18:15:41 PDT
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. > > Would you take this please? > > I think the customStyleForRenderr() should be: > > - RefPtr<RenderStyle> style = RenderStyle::create(); > + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);
Ah, we need to clone it because we modify it. RefPtr<RenderStyle> originalStyle = document()->styleResolver()->styleForElement(this); RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());
Garrett Casto
Comment 5
2012-05-30 13:20:18 PDT
Created
attachment 144902
[details]
Patch
Kent Tamura
Comment 6
2012-05-30 18:49:06 PDT
Comment on
attachment 144902
[details]
Patch Looks good
WebKit Review Bot
Comment 7
2012-05-30 19:02:06 PDT
Comment on
attachment 144902
[details]
Patch Clearing flags on attachment: 144902 Committed
r119020
: <
http://trac.webkit.org/changeset/119020
>
WebKit Review Bot
Comment 8
2012-05-30 19:02:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug