Bug 87759 - [New Multicolumn] Pull the initial page logical height setup into its own virtual function
Summary: [New Multicolumn] Pull the initial page logical height setup into its own vir...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 11:01 PDT by Dave Hyatt
Modified: 2012-05-29 11:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2012-05-29 11:04 PDT, Dave Hyatt 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-05-29 11:01:48 PDT 
Pull the initial page logical height setup into its own virtual function. This will allow RenderMultiColumnBlock to do the setup in the derived class (and also makes layoutBlock a little cleaner in the base class even for the old multi-column layout).
Comment 1 Dave Hyatt 2012-05-29 11:04:02 PDT 
Created attachment 144587 [details]
Patch
Comment 2 Dave Hyatt 2012-05-29 11:05:20 PDT 
Comment on attachment 144587 [details]
Patch

The diff for this looks really funny for anyone reviewing. The code that actually got pulled into the helper function doesn't show up in the diff, since it chose to show the movement of the layoutBlock code instead. I recommend looking at the current source to understand what I did here.
Comment 3 WebKit Review Bot 2012-05-29 11:06:26 PDT 
Attachment 144587 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:1399:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:1399:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2012-05-29 11:15:30 PDT 
Landed in r118808.