Bug 87745 - [GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
Summary: [GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 07:20 PDT by Simon Pena
Modified: 2012-05-29 09:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2012-05-29 07:41 PDT, Simon Pena
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2012-05-29 07:20:26 PDT
Building WK2 currently outputs the following warnings:

../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:194:5: warning: missing initializer for member ‘WKPageUIClient::unavailablePluginButtonClicked’ [-Wmissing-field-initializers]
../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:151:5: warning: missing initializer for member ‘WKPageLoaderClient::pluginDidFail’ [-Wmissing-field-initializers]

The attached patch initializes these members.
Comment 1 Simon Pena 2012-05-29 07:41:55 PDT
Created attachment 144556 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-29 07:44:28 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2012-05-29 07:53:03 PDT
Comment on attachment 144556 [details]
Patch

Thanks!
Comment 4 WebKit Review Bot 2012-05-29 09:47:19 PDT
Comment on attachment 144556 [details]
Patch

Clearing flags on attachment: 144556

Committed r118795: <http://trac.webkit.org/changeset/118795>
Comment 5 WebKit Review Bot 2012-05-29 09:47:24 PDT
All reviewed patches have been landed.  Closing bug.