Bug 87727 - [EFL] Enable CSS_IMAGE_SET flag
Summary: [EFL] Enable CSS_IMAGE_SET flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 04:11 PDT by Chris Dumez
Modified: 2012-05-31 07:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2012-05-29 04:17 PDT, Chris Dumez 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2012-05-29 10:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2012-05-29 10:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.27 KB, patch)
2012-05-29 11:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-29 04:11:23 PDT 
We need to enable the CSS_IMAGE_SET flag on EFL port. It is tested by:
  fast/css/image-set-parsing.html

It is already enabled at least on Mac and Chromium ports.

See this email for more information about this feature:
https://lists.webkit.org/pipermail/webkit-dev/2012-March/019722.html
Comment 1 Chris Dumez 2012-05-29 04:17:39 PDT 
Created attachment 144510 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-29 06:54:57 PDT 
Comment on attachment 144510 [details]
Patch

Attachment 144510 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12849482
Comment 3 Chris Dumez 2012-05-29 10:02:12 PDT 
Created attachment 144574 [details]
Patch
Comment 4 Chris Dumez 2012-05-29 10:18:21 PDT 
Created attachment 144579 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-29 10:34:16 PDT 
Comment on attachment 144579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144579&action=review

The feature itself seems to have been landed the wrong way, with a define in Platform.h instead of being added to FeatureList.pm, which is sad.

> Source/WebCore/CMakeLists.txt:1518
> +IF (ENABLE_CSS_IMAGE_SET)
> +    LIST(APPEND WebCore_SOURCES
> +        css/CSSImageSetValue.cpp
> +        rendering/style/StyleCachedImageSet.cpp
> +    )
> +ENDIF ()

These files are already protected by ENABLE(CSS_IMAGE_SET) ifdefs, so they can be added unconditionally to the build.
Comment 6 Chris Dumez 2012-05-29 11:15:26 PDT 
Created attachment 144590 [details]
Patch

Take rakuco's feedback into consideration.
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-05-29 11:28:23 PDT 
Comment on attachment 144590 [details]
Patch

LGTM.
Comment 8 Gyuyoung Kim 2012-05-29 17:49:27 PDT 
Comment on attachment 144590 [details]
Patch

Looks good to me.
Comment 9 WebKit Review Bot 2012-05-31 07:47:45 PDT 
Comment on attachment 144590 [details]
Patch

Clearing flags on attachment: 144590

Committed r119102: <http://trac.webkit.org/changeset/119102>
Comment 10 WebKit Review Bot 2012-05-31 07:47:50 PDT 
All reviewed patches have been landed.  Closing bug.