Bug 87726 - Split svg/dom/viewspec-parser.html in smaller tests
Summary: Split svg/dom/viewspec-parser.html in smaller tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcus Bulach
Depends on:
Blocks: 87772
  Show dependency treegraph
Reported: 2012-05-29 04:06 PDT by Marcus Bulach
Modified: 2012-06-01 11:49 PDT (History)
1 user (show)

See Also:

Patch (208.54 KB, patch)
2012-05-29 04:13 PDT, Marcus Bulach
no flags Details | Formatted Diff | Diff
Patch (248.99 KB, patch)
2012-05-29 06:21 PDT, Marcus Bulach
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Bulach 2012-05-29 04:06:51 PDT
svg/dom/viewspec-parser.html introduced by r118735 is a very large test that times out on chromium.
Split in 5 smaller tests.
Comment 1 Marcus Bulach 2012-05-29 04:13:20 PDT
Created attachment 144509 [details]
Comment 2 Andreas Kling 2012-05-29 06:09:20 PDT
Comment on attachment 144509 [details]

LGTM, but don't forget to remove viewspec-parser-expected.txt as well.
Comment 3 Marcus Bulach 2012-05-29 06:21:26 PDT
Created attachment 144539 [details]
Comment 4 Marcus Bulach 2012-05-29 07:53:35 PDT
Committed r118776: <http://trac.webkit.org/changeset/118776>
Comment 5 Alexey Proskuryakov 2012-06-01 11:49:41 PDT
These new tests are very flaky on bots. Could you please take a look?


-This test fuzzes the transform parser with semi-random attribute values and dumps the results of any values that parse successfully.
+FAIL: Timed out waiting for notifyDone to be called
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".