The simulator has decent OpenGL support these days, we just have to turn on ENABLE_GLES2
Created attachment 144502 [details] Patch
This stuff was reviewed internally by George Staikos (PR #150695)
Comment on attachment 144502 [details] Patch Rejecting attachment 144502 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 8] _ssl.c:490: EOF occurred in violation of protocol> Full output: http://queues.webkit.org/results/12845536
Comment on attachment 144502 [details] Patch try again, I think the commit-queue fluked out
Comment on attachment 144502 [details] Patch Rejecting attachment 144502 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Hunk #1 FAILED at 930. Hunk #2 FAILED at 957. 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12840634
(In reply to comment #5) > (From update of attachment 144502 [details]) > Rejecting attachment 144502 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Parsed 2 diffs from patch file(s). > patching file Tools/ChangeLog > Hunk #1 succeeded at 1 with fuzz 3. > patching file Tools/Scripts/webkitdirs.pm > Hunk #1 FAILED at 930. > Hunk #2 FAILED at 957. > 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/12840634 Gosh, I uploaded a patch based on master_35, not svn/master =(
(In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 144502 [details] [details]) > > Rejecting attachment 144502 [details] [details] from commit-queue. > > > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > > > Last 500 characters of output: > > eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > > > Parsed 2 diffs from patch file(s). > > patching file Tools/ChangeLog > > Hunk #1 succeeded at 1 with fuzz 3. > > patching file Tools/Scripts/webkitdirs.pm > > Hunk #1 FAILED at 930. > > Hunk #2 FAILED at 957. > > 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej > > > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > > > Full output: http://queues.webkit.org/results/12840634 > > Gosh, I uploaded a patch based on master_35, not svn/master =( No, that wasn't it - apparently this patch is landed, but the CQ failed to mark the bug as fixed.
It's landed
Landed in http://trac.webkit.org/changeset/118777
Comment on attachment 144502 [details] Patch Clearing flags like CQ usually does
Hi Arvid, (In reply to comment #10) > (From update of attachment 144502 [details]) > Clearing flags like CQ usually does You can use webkit-patch mark-bug-fixed to close the bug from the command line, with a standardized message.