Bug 87715 - [CSS] Remove a dummy style sheet from CSSParser::parseFlowThread()
Summary: [CSS] Remove a dummy style sheet from CSSParser::parseFlowThread()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 87625
  Show dependency treegraph
 
Reported: 2012-05-29 02:35 PDT by Kentaro Hara
Modified: 2012-05-29 21:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2012-05-29 02:36 PDT, Kentaro Hara
haraken: commit-queue-
Details | Formatted Diff | Diff
patch for landing (1.59 KB, patch)
2012-05-29 17:10 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-29 02:35:19 PDT
r118736 changed CSSGrammer.y so that it works fine with no style sheet. r118736 removed a dummy style sheet from CSSParser::parserSelector().

Now we can safely remove a dummy style sheet from parserFlowThread().
Comment 1 Kentaro Hara 2012-05-29 02:36:44 PDT
Created attachment 144494 [details]
Patch
Comment 2 Darin Adler 2012-05-29 13:02:28 PDT
Comment on attachment 144494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144494&action=review

> Source/WebCore/ChangeLog:3
> +        [CSS] Remove a dummy style sheet from CSSParser::parseFlowThread()

I don’t think we need a [CSS] prefix on a CSS bug title.

> Source/WebCore/ChangeLog:8
> +        r118736 changed CSSGrammer.y so that it works fine with no style sheet.

CSSGrammar is misspelled here.
Comment 3 Kentaro Hara 2012-05-29 15:08:01 PDT
Comment on attachment 144494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144494&action=review

>> Source/WebCore/ChangeLog:8
>> +        r118736 changed CSSGrammer.y so that it works fine with no style sheet.
> 
> CSSGrammar is misspelled here.

Oops. Let me fix it.
Comment 4 Kentaro Hara 2012-05-29 17:10:53 PDT
Created attachment 144647 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-05-29 21:37:40 PDT
Comment on attachment 144647 [details]
patch for landing

Clearing flags on attachment: 144647

Committed r118892: <http://trac.webkit.org/changeset/118892>