Bug 87710 – Allow ports to make plugins focusable

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Adam Barth]

Allow ports to make plugins focusable

[Adam Barth]

Created attachment 144478 [details]
Patch

[Adam Barth]

Comment on attachment 144478 [details]
Patch

Clearing the review flag for a moment.  I need to study the interaction between this patch and one other thing.

[Peter Beverloo]

+epenner

This seems to be quite old code, Eric (Penner), could you comment on whether we want this upstreamed right now?

[Alexey Proskuryakov]

This is surprising, because I can certainly focus Flash plug-ins to type in them in Safari on Mac and Windows. Keyboard also works in YouTube for controlling movies.

[Adam Barth]

Yes, I believe this patch isn't correct.  I'll post a patch to the chromium-android branch to remove it.

[Eric Penner]

This was needed to support the case where events should only arrive when the plugin has focus, rather than all the time.

In that case this is needed to insure the plugin gets focus when desired which is slightly different from when it would normally get focus. The code is indeed old, but I believe it's a valid use-case for plugins, when you don't always want them to receive events on a mobile device (but rather only when you tap on it first).

[Adam Barth]

As far as I know, we're abandoning support for plugins on the chromium-android branch.  That means instead of moving this patch upstream, we should remove it from downstream.  If there's another reason to make this change, we can make the change again in the future when we have that need.