SSIA
Created attachment 144444 [details] Patch
Attachment 144444 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.h:59: webkit_video_sink_get_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 144444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144444&action=review Other that the comment rs=me > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:42 > +static GstStaticPadTemplate sinkTemplate = GST_STATIC_PAD_TEMPLATE("sink", GST_PAD_SINK, GST_PAD_ALWAYS, GST_STATIC_CAPS(WEBKIT_VIDEO_SINK_PAD_CAPS)); The static variable should start with s_ isn't it?
(In reply to comment #3) > (From update of attachment 144444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144444&action=review > > Other that the comment rs=me > > > Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:42 > > +static GstStaticPadTemplate sinkTemplate = GST_STATIC_PAD_TEMPLATE("sink", GST_PAD_SINK, GST_PAD_ALWAYS, GST_STATIC_CAPS(WEBKIT_VIDEO_SINK_PAD_CAPS)); > > The static variable should start with s_ isn't it? Ah yes indeed. Thanks for the review!
Committed r118789: <http://trac.webkit.org/changeset/118789>