RESOLVED FIXED 87692
[V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm 
https://bugs.webkit.org/show_bug.cgi?id=87692
Summary [V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
Kentaro Hara
Reported 2012-05-28 21:31:17 PDT
Since v8::Null(isolate) crashes if we pass a NULL isolate, we are planning to pass Isolate to v8::Null() in the following steps: [1] Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check. If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise, v8Null(isolate) calls v8::Null(isolate). [2] In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a non-optional 'isolate' parameter. (e.g. void foo(..., Isolate* isolate) { v8::Null(); } ) [3] In V8 bindings, we replace v8::Null() with v8Null(isolate) for an optional 'isolate' parameter. (e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } ) This bug fixes [1].
Attachments
Patch (23.89 KB, patch)
2012-05-28 22:41 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-28 22:41:58 PDT
Created attachment 144447 [details] Patch
Adam Barth
Comment 2 2012-05-28 22:59:48 PDT
Looks great.
WebKit Review Bot
Comment 3 2012-05-28 23:42:29 PDT
Comment on attachment 144447 [details] Patch Clearing flags on attachment: 144447 Committed r118726: <http://trac.webkit.org/changeset/118726>
WebKit Review Bot
Comment 4 2012-05-28 23:42:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.