Bug 87692 - [V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
Summary: [V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-05-28 21:31 PDT by Kentaro Hara
Modified: 2012-06-01 15:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.89 KB, patch)
2012-05-28 22:41 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-28 21:31:17 PDT 
Since v8::Null(isolate) crashes if we pass a NULL isolate, we are planning to pass Isolate to v8::Null() in the following steps:

[1] Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check. If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise, v8Null(isolate) calls v8::Null(isolate).

[2] In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a non-optional 'isolate' parameter. (e.g. void foo(..., Isolate* isolate) { v8::Null(); } )

[3] In V8 bindings, we replace v8::Null() with v8Null(isolate) for an optional 'isolate' parameter. (e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )

This bug fixes [1].
Comment 1 Kentaro Hara 2012-05-28 22:41:58 PDT 
Created attachment 144447 [details]
Patch
Comment 2 Adam Barth 2012-05-28 22:59:48 PDT 
Looks great.
Comment 3 WebKit Review Bot 2012-05-28 23:42:29 PDT 
Comment on attachment 144447 [details]
Patch

Clearing flags on attachment: 144447

Committed r118726: <http://trac.webkit.org/changeset/118726>
Comment 4 WebKit Review Bot 2012-05-28 23:42:34 PDT 
All reviewed patches have been landed.  Closing bug.