Bug 87690 – [Chromium] Cannot show suggestions when using asynchronous spellchecking

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Hironori Bono]

Greetings,

Due to Chromium Change r137831 <http://crrev.com/137831>, Chromium does not attach suggestions to markers when using asynchronous spellchecking. That is, Chromium always shows "no suggestions" when running Chromium with an "--enable-asynchronous-spellchecking" option and right-clicking a misspelled word, e.g. "thisis". To fix this issue, would it be possible to use local spellcheckers as a fallback method when a marker doss not include suggestions?

Regards,

Hironori Bono

[Hironori Bono]

Created attachment 144434 [details]
Patch v0

Greetings Morita-san and Tamura-san,

Sorry for disturbing you. Would it be possible to review this small change?

Regards,

Hironori Bono

[Hajime Morrita]

Comment on attachment 144434 [details]
Patch v0

View in context: https://bugs.webkit.org/attachment.cgi?id=144434&action=review

The code looks good. Please fix typos before landing.

> Source/WebKit/chromium/ChangeLog:8
> +        This change uses WebSpellCheckClient::spellcheck as a follback method to

s/follback/fallback

> Source/WebKit/chromium/ChangeLog:11
> +        afford to attach suggestions to all Spelling markers.)

s/Spelling/spelling

[Hironori Bono]

Created attachment 144440 [details]
Patch v1 (fixed typos)

Morita-san,

Many thank for your quick review and finding typos. I have uploaded a new change that fixed them.

Regards,

Hironori Bono

[WebKit Review Bot]

Comment on attachment 144440 [details]
Patch v1 (fixed typos)

Clearing flags on attachment: 144440

Committed r118740: <http://trac.webkit.org/changeset/118740>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.