Bug 87690 - [Chromium] Cannot show suggestions when using asynchronous spellchecking
Summary: [Chromium] Cannot show suggestions when using asynchronous spellchecking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 20:02 PDT by Hironori Bono
Modified: 2012-05-29 02:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch v0 (2.17 KB, patch)
2012-05-28 20:17 PDT, Hironori Bono 		morrita: review+
morrita: commit-queue-
Details | Formatted Diff | Diff
Patch v1 (fixed typos) (2.17 KB, patch)
2012-05-28 21:31 PDT, Hironori Bono 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hironori Bono 2012-05-28 20:02:11 PDT 
Greetings,

Due to Chromium Change r137831 <http://crrev.com/137831>, Chromium does not attach suggestions to markers when using asynchronous spellchecking. That is, Chromium always shows "no suggestions" when running Chromium with an "--enable-asynchronous-spellchecking" option and right-clicking a misspelled word, e.g. "thisis". To fix this issue, would it be possible to use local spellcheckers as a fallback method when a marker doss not include suggestions?

Regards,

Hironori Bono
Comment 1 Hironori Bono 2012-05-28 20:17:33 PDT 
Created attachment 144434 [details]
Patch v0

Greetings Morita-san and Tamura-san,

Sorry for disturbing you. Would it be possible to review this small change?

Regards,

Hironori Bono
Comment 2 Hajime Morrita 2012-05-28 21:00:10 PDT 
Comment on attachment 144434 [details]
Patch v0

View in context: https://bugs.webkit.org/attachment.cgi?id=144434&action=review

The code looks good. Please fix typos before landing.

> Source/WebKit/chromium/ChangeLog:8
> +        This change uses WebSpellCheckClient::spellcheck as a follback method to

s/follback/fallback

> Source/WebKit/chromium/ChangeLog:11
> +        afford to attach suggestions to all Spelling markers.)

s/Spelling/spelling
Comment 3 Hironori Bono 2012-05-28 21:31:44 PDT 
Created attachment 144440 [details]
Patch v1 (fixed typos)

Morita-san,

Many thank for your quick review and finding typos. I have uploaded a new change that fixed them.

Regards,

Hironori Bono
Comment 4 WebKit Review Bot 2012-05-29 02:11:01 PDT 
Comment on attachment 144440 [details]
Patch v1 (fixed typos)

Clearing flags on attachment: 144440

Committed r118740: <http://trac.webkit.org/changeset/118740>
Comment 5 WebKit Review Bot 2012-05-29 02:11:08 PDT 
All reviewed patches have been landed.  Closing bug.