Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Created attachment 144411 [details] Patch
Comment on attachment 144411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +const char* const transformName[22] = { I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum.
Comment on attachment 144411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review >> Source/WebCore/css/WebKitCSSTransformValue.cpp:36 >> +const char* const transformName[22] = { > > I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". > > I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum. Agreed on both points.
Created attachment 144640 [details] Patch
Comment on attachment 144640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144640&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +// These names must be kept in sync with TransformOperationType. Normally to keep something in sync we need comments on both things, otherwise someone changes one without updating the other.
Comment on attachment 144640 [details] Patch Clearing flags on attachment: 144640 Committed r118885: <http://trac.webkit.org/changeset/118885>
All reviewed patches have been landed. Closing bug.