Bug 87684 - Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Summary: Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 17:08 PDT by Luke Macpherson
Modified: 2012-05-29 20:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2012-05-28 17:11 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2012-05-29 16:48 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-05-28 17:08:14 PDT
Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Comment 1 Luke Macpherson 2012-05-28 17:11:06 PDT
Created attachment 144411 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-05-29 00:44:28 PDT
Comment on attachment 144411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> +const char* const transformName[22] = {

I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...".

I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum.
Comment 3 Darin Adler 2012-05-29 09:46:19 PDT
Comment on attachment 144411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review

>> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
>> +const char* const transformName[22] = {
> 
> I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...".
> 
> I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum.

Agreed on both points.
Comment 4 Luke Macpherson 2012-05-29 16:48:43 PDT
Created attachment 144640 [details]
Patch
Comment 5 Darin Adler 2012-05-29 17:28:35 PDT
Comment on attachment 144640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144640&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> +// These names must be kept in sync with TransformOperationType.

Normally to keep something in sync we need comments on both things, otherwise someone changes one without updating the other.
Comment 6 WebKit Review Bot 2012-05-29 20:30:41 PDT
Comment on attachment 144640 [details]
Patch

Clearing flags on attachment: 144640

Committed r118885: <http://trac.webkit.org/changeset/118885>
Comment 7 WebKit Review Bot 2012-05-29 20:30:46 PDT
All reviewed patches have been landed.  Closing bug.