Bug 87676 - [BlackBerry] Add malloc info to about:memory page
Summary: [BlackBerry] Add malloc info to about:memory page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P4 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 13:29 PDT by Yong Li
Modified: 2012-07-16 11:59 PDT (History)
5 users (show)

See Also:

Attachments
the patch (1.90 KB, patch)
2012-05-29 10:30 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
second try (1.90 KB, patch)
2012-05-29 10:33 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
again (5.12 KB, patch)
2012-05-29 14:16 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
make process total memory usage more readable. (2.87 KB, patch)
2012-07-16 10:51 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
add change log (3.54 KB, patch)
2012-07-16 11:28 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-05-28 13:29:27 PDT 
to add malloc info to about:memory page
Comment 1 Yong Li 2012-05-29 10:30:26 PDT 
Created attachment 144583 [details]
the patch
Comment 2 Yong Li 2012-05-29 10:33:03 PDT 
Created attachment 144584 [details]
second try
Comment 3 Konrad Piascik 2012-05-29 10:33:48 PDT 
Comment on attachment 144583 [details]
the patch

This is not related to the patch itself, but AboutData.cpp would benefit from a StringBuilder refactor.
Comment 4 WebKit Review Bot 2012-05-29 10:35:48 PDT 
Attachment 144584 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1
Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:222:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Konrad Piascik 2012-05-29 10:36:15 PDT 
Comment on attachment 144584 [details]
second try

View in context: https://bugs.webkit.org/attachment.cgi?id=144584&action=review

> Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:245
> +    page += "</body></html>";

shouldn't the </table> tag from line 242 be outside the #if define block?
Comment 6 Yong Li 2012-05-29 10:40:59 PDT 
Comment on attachment 144584 [details]
second try

I realized I can simplify the code with an existing function...

also, will add more info as suggested by Eli
Comment 7 Yong Li 2012-05-29 10:41:35 PDT 
(In reply to comment #5)
> (From update of attachment 144584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144584&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:245
> > +    page += "</body></html>";
> 
> shouldn't the </table> tag from line 242 be outside the #if define block?

yes. fixed by second patch
Comment 8 Yong Li 2012-05-29 13:48:27 PDT 
postponed
Comment 9 Yong Li 2012-05-29 14:16:13 PDT 
Created attachment 144618 [details]
again
Comment 10 Rob Buis 2012-05-29 14:19:42 PDT 
Comment on attachment 144618 [details]
again

Looks good.
Comment 11 Yong Li 2012-05-29 14:40:58 PDT 
reopen
Comment 12 WebKit Review Bot 2012-05-29 15:59:32 PDT 
Comment on attachment 144618 [details]
again

Clearing flags on attachment: 144618

Committed r118847: <http://trac.webkit.org/changeset/118847>
Comment 13 WebKit Review Bot 2012-05-29 15:59:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Yong Li 2012-07-13 12:06:27 PDT 
reopen to make a change
Comment 15 Yong Li 2012-07-16 10:51:31 PDT 
Created attachment 152564 [details]
make process total memory usage more readable.
Comment 16 Yong Li 2012-07-16 11:28:08 PDT 
Created attachment 152571 [details]
add change log
Comment 17 Rob Buis 2012-07-16 11:36:24 PDT 
Comment on attachment 152571 [details]
add change log

LGTM.
Comment 18 WebKit Review Bot 2012-07-16 11:59:40 PDT 
Comment on attachment 152571 [details]
add change log

Clearing flags on attachment: 152571

Committed r122745: <http://trac.webkit.org/changeset/122745>
Comment 19 WebKit Review Bot 2012-07-16 11:59:47 PDT 
All reviewed patches have been landed.  Closing bug.