Bug 87656 – Web Inspector: Add trace() method to the WorkerConsole

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

Add trace() method to the WorkerConsole.

[Alexei Filippov]

Created attachment 144346 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 144346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144346&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotWorker.js:70
> +        Error.captureStackTrace(obj, this.trace);

Doe this method work in JSC?

[Ilya Tikhonovsky]

Comment on attachment 144346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144346&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:71
> +            if (message.method !== "log" && message.method !== "info" && message.method !== "error" && message.method !== "trace") {

this line is not required

[Alexei Filippov]

Created attachment 144366 [details]
Patch

[Alexei Filippov]

Comment on attachment 144346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144346&action=review

>> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:71
>> +            if (message.method !== "log" && message.method !== "info" && message.method !== "error" && message.method !== "trace") {
> 
> this line is not required

yes, you're right! killed it.

>> Source/WebCore/inspector/front-end/HeapSnapshotWorker.js:70
>> +        Error.captureStackTrace(obj, this.trace);
> 
> Doe this method work in JSC?

I'm not sure, but I doubt it works. Does it have to? It is never called in JSC.

[Yury Semikhatsky]

(In reply to comment #5)
> >> Source/WebCore/inspector/front-end/HeapSnapshotWorker.js:70
> >> +        Error.captureStackTrace(obj, this.trace);
> > 
> > Doe this method work in JSC?
> 
> I'm not sure, but I doubt it works. Does it have to? It is never called in JSC.

Heap snapshot front-end should work with both engines even though there is no support for heap profiling on the backend running JSC so please check if JSC supports Error.captureStackTrace and if it doesn't use something more portable, probably new Error().stack

[Alexei Filippov]

Created attachment 144580 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 144580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144580&action=review

Could you please reply to my previous comment to make it clear if JSC supports Error.captureStackTrace

> Source/WebCore/inspector/front-end/HeapSnapshotWorker.js:75
> +            for (var func = arguments.callee; func; func = func.caller)

Why not new Error().stack?

[Alexei Filippov]

Created attachment 144783 [details]
Patch

[Alexei Filippov]

(In reply to comment #8)
> (From update of attachment 144580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144580&action=review
> 
> Could you please reply to my previous comment to make it clear if JSC supports Error.captureStackTrace
Looks like it is not.

> 
> > Source/WebCore/inspector/front-end/HeapSnapshotWorker.js:75
> > +            for (var func = arguments.callee; func; func = func.caller)
> 
> Why not new Error().stack?
Done it this way.

[WebKit Review Bot]

Comment on attachment 144783 [details]
Patch

Clearing flags on attachment: 144783

Committed r118921: <http://trac.webkit.org/changeset/118921>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.