Bug 87655 - Web Inspector: Retainers are missing for all objects
Summary: Web Inspector: Retainers are missing for all objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 06:14 PDT by Alexei Filippov
Modified: 2012-05-31 01:05 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2012-05-28 06:18 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2012-05-29 05:37 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Patch (6.26 KB, patch)
2012-05-29 07:24 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2012-05-30 05:55 PDT, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-05-28 06:14:53 PDT 
The retainers view is empty.
Comment 1 Alexei Filippov 2012-05-28 06:18:01 PDT 
Created attachment 144343 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-28 06:50:18 PDT 
Can we have a test for this?
Comment 3 Alexei Filippov 2012-05-29 05:37:35 PDT 
Created attachment 144529 [details]
Patch
Comment 4 Alexei Filippov 2012-05-29 05:39:10 PDT 
Added a test.
Comment 5 Yury Semikhatsky 2012-05-29 06:13:23 PDT 
Comment on attachment 144529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144529&action=review

> LayoutTests/inspector/profiler/heap-snapshot-test.js:341
> +InspectorTest.clickRow = function(row, callback)

The method should have more specific name reflecting that it will pass retainers root to the callback.

> LayoutTests/inspector/profiler/heap-snapshot-test.js:355
> +        setTimeout(function() { callback(rootNode); }, 0);

Why do you need this setTimeout ?
Comment 6 Alexei Filippov 2012-05-29 07:24:01 PDT 
Created attachment 144553 [details]
Patch
Comment 7 WebKit Review Bot 2012-05-29 09:36:23 PDT 
Comment on attachment 144553 [details]
Patch

Clearing flags on attachment: 144553

Committed r118793: <http://trac.webkit.org/changeset/118793>
Comment 8 WebKit Review Bot 2012-05-29 09:36:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexey Proskuryakov 2012-05-29 10:23:40 PDT 
This test is failing on all JSC platforms. Skipped on Mac in <http://trac.webkit.org/changeset/118802>.
Comment 10 Alexei Filippov 2012-05-30 05:55:30 PDT 
Reopening to attach new patch.
Comment 11 Alexei Filippov 2012-05-30 05:55:35 PDT 
Created attachment 144791 [details]
Patch
Comment 12 Yury Semikhatsky 2012-05-31 00:35:42 PDT 
(In reply to comment #10)
> Reopening to attach new patch.

We usually create a new bug for such fixes.
Comment 13 WebKit Review Bot 2012-05-31 01:05:25 PDT 
Comment on attachment 144791 [details]
Patch

Clearing flags on attachment: 144791

Committed r119071: <http://trac.webkit.org/changeset/119071>
Comment 14 WebKit Review Bot 2012-05-31 01:05:31 PDT 
All reviewed patches have been landed.  Closing bug.