RESOLVED FIXED 87655
Web Inspector: Retainers are missing for all objects 
https://bugs.webkit.org/show_bug.cgi?id=87655
Summary Web Inspector: Retainers are missing for all objects
Alexei Filippov
Reported 2012-05-28 06:14:53 PDT
The retainers view is empty.
Attachments
Patch (1.59 KB, patch)
2012-05-28 06:18 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2012-05-29 05:37 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2012-05-29 07:24 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2012-05-30 05:55 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-05-28 06:18:01 PDT
Created attachment 144343 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-28 06:50:18 PDT
Can we have a test for this?
Alexei Filippov
Comment 3 2012-05-29 05:37:35 PDT
Created attachment 144529 [details] Patch
Alexei Filippov
Comment 4 2012-05-29 05:39:10 PDT
Added a test.
Yury Semikhatsky
Comment 5 2012-05-29 06:13:23 PDT
Comment on attachment 144529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144529&action=review > LayoutTests/inspector/profiler/heap-snapshot-test.js:341 > +InspectorTest.clickRow = function(row, callback) The method should have more specific name reflecting that it will pass retainers root to the callback. > LayoutTests/inspector/profiler/heap-snapshot-test.js:355 > + setTimeout(function() { callback(rootNode); }, 0); Why do you need this setTimeout ?
Alexei Filippov
Comment 6 2012-05-29 07:24:01 PDT
Created attachment 144553 [details] Patch
WebKit Review Bot
Comment 7 2012-05-29 09:36:23 PDT
Comment on attachment 144553 [details] Patch Clearing flags on attachment: 144553 Committed r118793: <http://trac.webkit.org/changeset/118793>
WebKit Review Bot
Comment 8 2012-05-29 09:36:27 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 9 2012-05-29 10:23:40 PDT
This test is failing on all JSC platforms. Skipped on Mac in <http://trac.webkit.org/changeset/118802>.
Alexei Filippov
Comment 10 2012-05-30 05:55:30 PDT
Reopening to attach new patch.
Alexei Filippov
Comment 11 2012-05-30 05:55:35 PDT
Created attachment 144791 [details] Patch
Yury Semikhatsky
Comment 12 2012-05-31 00:35:42 PDT
(In reply to comment #10) > Reopening to attach new patch. We usually create a new bug for such fixes.
WebKit Review Bot
Comment 13 2012-05-31 01:05:25 PDT
Comment on attachment 144791 [details] Patch Clearing flags on attachment: 144791 Committed r119071: <http://trac.webkit.org/changeset/119071>
WebKit Review Bot
Comment 14 2012-05-31 01:05:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.