Bug 87654 – [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

Evas key events already provide key string, for instance if the User presses 'Return' key the generated Evas_Event_Key_Down(_Up) events will contain following fields:
keyname = "Return", key = "Return", string = "\r", compose = "\r"
So no practical need for singleCharacterString() evaluating the event string from event keyname.
The only place where this function is currently used is DRT, however DRT EventSender also can provide event string itself.

[Mikhail Pozdnyakov]

Created attachment 144345 [details]
patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 144345 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144345&action=review

> Tools/DumpRenderTree/efl/EventSender.cpp:124
> +    KeyEventInfo(const CString& keyName, unsigned modifiers)
> +        : keyName(keyName)
> +        , modifiers(modifiers)

Instead of adding a new constructor, I'd change the order of parameters in the other one and make keyString an optional last parameter whose default value is an empty string.

[Mikhail Pozdnyakov]

Created attachment 144353 [details]
patch v2 (Review remarks are met)

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 144345 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144345&action=review
> 
> > Tools/DumpRenderTree/efl/EventSender.cpp:124
> > +    KeyEventInfo(const CString& keyName, unsigned modifiers)
> > +        : keyName(keyName)
> > +        , modifiers(modifiers)
> 
> Instead of adding a new constructor, I'd change the order of parameters in the other one and make keyString an optional last parameter whose default value is an empty string.

done.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 144353 [details]
patch v2 (Review remarks are met)

Looks good, thanks.

[Gyuyoung Kim]

Comment on attachment 144353 [details]
patch v2 (Review remarks are met)

Looks good to me too.

[Csaba Osztrogonác]

Comment on attachment 144353 [details]
patch v2 (Review remarks are met)

rs=me

[WebKit Review Bot]

Comment on attachment 144353 [details]
patch v2 (Review remarks are met)

Clearing flags on attachment: 144353

Committed r118760: <http://trac.webkit.org/changeset/118760>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.