Bug 87641 – [Shadow DOM] Add an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hayato Ito]

We should have an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching.

[Hayato Ito]

Created attachment 144335 [details]
add assertions

[Dimitri Glazkov (Google)]

Comment on attachment 144335 [details]
add assertions

View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review

> Source/WebCore/dom/EventContext.h:52
> +    bool accessible(Node*);

Might as well not compile it in NDEBUG.

[Hayato Ito]

Thank you for the review.

(In reply to comment #2)
> (From update of attachment 144335 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review
> 
> > Source/WebCore/dom/EventContext.h:52
> > +    bool accessible(Node*);
> 
> Might as well not compile it in NDEBUG.

Okay. I'll guard it using NDEBUG. Let me land this patch after that.

[Hayato Ito]

Created attachment 144676 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 144676 [details]
Patch for landing

Clearing flags on attachment: 144676

Committed r118889: <http://trac.webkit.org/changeset/118889>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.