Bug 87636 - [EFL] Compilation warning in DumpRenderTreeView.cpp
Summary: [EFL] Compilation warning in DumpRenderTreeView.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 01:43 PDT by Chris Dumez
Modified: 2012-05-29 00:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-05-28 01:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2012-05-28 02:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-05-28 01:43:17 PDT 
We get the following compilation warning on the build bot:
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:135:36: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘int64_t {aka long int}’ [-Wformat]
Comment 1 Chris Dumez 2012-05-28 01:44:42 PDT 
Created attachment 144304 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-28 02:11:29 PDT 
Comment on attachment 144304 [details]
Patch

Looks fine. By the way,  don't you need to fix return type as well ?

static *int64_t* onExceededApplicationCacheQuota ?
Comment 3 Chris Dumez 2012-05-28 02:41:31 PDT 
(In reply to comment #2)
> (From update of attachment 144304 [details])
> Looks fine. By the way,  don't you need to fix return type as well ?
> 
> static *int64_t* onExceededApplicationCacheQuota ?

It makes sense.
Comment 4 Chris Dumez 2012-05-28 02:45:14 PDT 
Created attachment 144310 [details]
Patch
Comment 5 Gyuyoung Kim 2012-05-28 03:53:55 PDT 
Comment on attachment 144310 [details]
Patch

Looks good to me now.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-28 06:39:27 PDT 
Comment on attachment 144310 [details]
Patch

Looks good, thanks.
Comment 7 WebKit Review Bot 2012-05-29 00:51:40 PDT 
Comment on attachment 144310 [details]
Patch

Clearing flags on attachment: 144310

Committed r118729: <http://trac.webkit.org/changeset/118729>
Comment 8 WebKit Review Bot 2012-05-29 00:51:46 PDT 
All reviewed patches have been landed.  Closing bug.