1. Go to Timeline and start recording events. 2. Switch to the memory view. See DOM counters graphs there. 3. Stop recording and switch to the events view and back. Result: counters section is cleared.
Also there is an exception in the console on click in the counters area. [12433:12433:236022046902:ERROR:CONSOLE(309)] "Uncaught TypeError: Cannot read property 'time' of undefined", source: chrome-devtools://devtools/MemoryStatistics.js (309)
Created attachment 144295 [details] Patch
Comment on attachment 144295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > - addTimlineEvent: function(event) Could you please fix spelling (addTimelineEvent) while you are at it?
Comment on attachment 144295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > + addTimlineEvent: function(record) addTimelineRecord?
Created attachment 144319 [details] Patch for landing
(In reply to comment #3) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > > - addTimlineEvent: function(event) > > Could you please fix spelling (addTimelineEvent) while you are at it? Done. Renamed the method. (In reply to comment #4) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Good point. Done. > > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > > + addTimlineEvent: function(record) > > addTimelineRecord? Done.
Committed r118670: <http://trac.webkit.org/changeset/118670>