Bug 87628 - Web Inspector: dom counters graphs vanish on switching between timeline views
Summary: Web Inspector: dom counters graphs vanish on switching between timeline views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-28 00:32 PDT by Yury Semikhatsky
Modified: 2012-05-28 03:20 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.07 KB, patch)
2012-05-28 01:03 PDT, Yury Semikhatsky
vsevik: review+
Details | Formatted Diff | Diff
Patch for landing (4.27 KB, patch)
2012-05-28 03:17 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-05-28 00:32:30 PDT
1. Go to Timeline and start recording events.
2. Switch to the memory view. See DOM counters graphs there.
3. Stop recording and switch to the events view and back.

Result: counters section is cleared.
Comment 1 Yury Semikhatsky 2012-05-28 00:33:28 PDT
Also there is an exception in the console on click in the counters area.

[12433:12433:236022046902:ERROR:CONSOLE(309)] "Uncaught TypeError: Cannot read property 'time' of undefined", source: chrome-devtools://devtools/MemoryStatistics.js (309)
Comment 2 Yury Semikhatsky 2012-05-28 01:03:51 PDT
Created attachment 144295 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-05-28 01:43:50 PDT
Comment on attachment 144295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review

> Source/WebCore/inspector/front-end/MemoryStatistics.js:-254
> -    addTimlineEvent: function(event)

Could you please fix spelling (addTimelineEvent) while you are at it?
Comment 4 Andrey Kosyakov 2012-05-28 02:57:39 PDT
Comment on attachment 144295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review

This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model.

> Source/WebCore/inspector/front-end/MemoryStatistics.js:254
> +    addTimlineEvent: function(record)

addTimelineRecord?
Comment 5 Yury Semikhatsky 2012-05-28 03:17:57 PDT
Created attachment 144319 [details]
Patch for landing
Comment 6 Yury Semikhatsky 2012-05-28 03:18:47 PDT
(In reply to comment #3)
> (From update of attachment 144295 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review
> 
> > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254
> > -    addTimlineEvent: function(event)
> 
> Could you please fix spelling (addTimelineEvent) while you are at it?
Done. Renamed the method.

(In reply to comment #4)
> (From update of attachment 144295 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review
> 
> This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model.
> 
Good point. Done.

> > Source/WebCore/inspector/front-end/MemoryStatistics.js:254
> > +    addTimlineEvent: function(record)
> 
> addTimelineRecord?
Done.
Comment 7 Yury Semikhatsky 2012-05-28 03:20:56 PDT
Committed r118670: <http://trac.webkit.org/changeset/118670>