Bug 87608 - HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
Summary: HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 87223
  Show dependency tree / graph
 
Reported: 2012-05-27 18:35 PDT by Hajime Morrita
Modified: 2012-05-28 02:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2012-05-27 19:02 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (2.47 KB, patch)
2012-05-27 21:59 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-05-27 18:35:26 PDT 
This is a preparation for Bug 87223. 

ValidationMessage mutates DOM tree. But mutating DOM tree during detach() causes troubles
which we hit by the change on Bug 87223.

It could be moved to removedFrom().
Comment 1 Hajime Morrita 2012-05-27 19:02:32 PDT 
Created attachment 144256 [details]
Patch
Comment 2 Kent Tamura 2012-05-27 21:04:12 PDT 
Comment on attachment 144256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144256&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:76
>  void HTMLFormControlElement::detach()
>  {
> -    m_validationMessage = nullptr;
>      HTMLElement::detach();
>  }

So, we can remove HTMLFormControlElement::detach().
Comment 3 Hajime Morrita 2012-05-27 21:25:17 PDT 
Comment on attachment 144256 [details]
Patch

> So, we can remove HTMLFormControlElement::detach().
True. will do. Thanks for taking look!
Comment 4 Hajime Morrita 2012-05-27 21:59:31 PDT 
Created attachment 144264 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-05-28 02:54:21 PDT 
Comment on attachment 144264 [details]
Patch for landing

Clearing flags on attachment: 144264

Committed r118664: <http://trac.webkit.org/changeset/118664>
Comment 6 WebKit Review Bot 2012-05-28 02:54:26 PDT 
All reviewed patches have been landed.  Closing bug.