Bug 87601 – [BlackBerry] Add support for layers with scale invariant size

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Arvid Nilsson]

To support layers that have a "floating" appearance, i.e. don't change size
    when the web page is drawn at a different scale, we add a new layer property
    named "sizeIsScaleInvariant".
    
    The anchor position will still be given in document coordinates for these
    "floating" layers, so this is well suited for interface elements like selection
    handles whose size is always the same but move with the web page contents.
    
    PR #156812


Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.

[Arvid Nilsson]

Created attachment 144243 [details]
Patch

[Arvid Nilsson]

Comment on attachment 144243 [details]
Patch

Hang on, something's not quite right here

[Arvid Nilsson]

Created attachment 144248 [details]
Patch

[Yong Li]

Comment on attachment 144248 [details]
Patch

Minor: It is a little bit weird to me "scale" is the first argument even it can be ignored. Does it make sense to store 1/scale if it is used very often?

internally LGTM

[Rob Buis]

Comment on attachment 144248 [details]
Patch

Ok.

[Arvid Nilsson]

(In reply to comment #4)
> (From update of attachment 144248 [details])
> Minor: It is a little bit weird to me "scale" is the first argument even it can be ignored. Does it make sense to store 1/scale if it is used very often?
> 
> internally LGTM

Layers which use 1/scale are very uncommon, it's only the selection handles andd fcc.

I initially had it last, then moved it first on a whim... It doesn't matter all that much does it? I was thinking about the order you'd use the params (if you used them all)

[Arvid Nilsson]

Created attachment 144395 [details]
Patch

[Arvid Nilsson]

Comment on attachment 144395 [details]
Patch

The dependency, #87600 changed after review comments, so this one needed to be updated to apply cleanly.

[Rob Buis]

Comment on attachment 144395 [details]
Patch

Looks fine.

[WebKit Review Bot]

Comment on attachment 144395 [details]
Patch

Clearing flags on attachment: 144395

Committed r118710: <http://trac.webkit.org/changeset/118710>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.