Bug 87598 - [BlackBerry] Always create a compositor
Summary: [BlackBerry] Always create a compositor
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
Depends on: 87590
Blocks: 87600
  Show dependency treegraph
Reported: 2012-05-27 15:00 PDT by Arvid Nilsson
Modified: 2012-05-28 12:57 PDT (History)
8 users (show)

See Also:

Patch (7.92 KB, patch)
2012-05-27 15:29 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-05-27 15:00:12 PDT
There will likely be compositing layers either due to web content or
    due to overlays.
    Defer initialization of OpenGL objects (i.e., delay creation of the
    LayerRenderer object) until we actually need to draw and there are such
    layers, to avoid initializing OpenGL in the unlikely case that there
    are no compositing layers or overlay layers.
    PR #156811

Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.
Comment 1 Arvid Nilsson 2012-05-27 15:29:26 PDT
Created attachment 144241 [details]
Comment 2 Mike Fenton 2012-05-28 08:35:19 PDT
Comment on attachment 144241 [details]

Looks good to me.
Comment 3 Rob Buis 2012-05-28 10:03:22 PDT
Comment on attachment 144241 [details]

Comment 4 WebKit Review Bot 2012-05-28 12:57:41 PDT
Comment on attachment 144241 [details]

Clearing flags on attachment: 144241

Committed r118704: <http://trac.webkit.org/changeset/118704>
Comment 5 WebKit Review Bot 2012-05-28 12:57:46 PDT
All reviewed patches have been landed.  Closing bug.