Bug 87586 - [watchlist] Add myself & a rule for MathML
Summary: [watchlist] Add myself & a rule for MathML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-26 21:18 PDT by Dave Barton
Modified: 2012-05-27 09:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2012-05-26 21:19 PDT, Dave Barton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Barton 2012-05-26 21:18:33 PDT 
[watchlist] Add myself & a rule for MathML
Comment 1 Dave Barton 2012-05-26 21:19:44 PDT 
Created attachment 144214 [details]
Patch
Comment 2 Adam Barth 2012-05-27 00:16:45 PDT 
Comment on attachment 144214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144214&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:159
> +            "filename": r".*mathml",

Do you need the .* in the beginning?  I guess it doesn't hurt.
Comment 3 WebKit Review Bot 2012-05-27 00:40:58 PDT 
Comment on attachment 144214 [details]
Patch

Clearing flags on attachment: 144214

Committed r118623: <http://trac.webkit.org/changeset/118623>
Comment 4 WebKit Review Bot 2012-05-27 00:41:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Dave Barton 2012-05-27 09:48:29 PDT 
Comment on attachment 144214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144214&action=review

>> Tools/Scripts/webkitpy/common/config/watchlist:159
>> +            "filename": r".*mathml",
> 
> Do you need the .* in the beginning?  I guess it doesn't hurt.

Yes, "filename" is a prefix match.

I've created bug 87592 with a patch to clarify this.

Thanks for the comment & review.