Bug 87583 - [Cairo] [OpenGL] Enable GL_OES_standard_derivatives
Summary: [Cairo] [OpenGL] Enable GL_OES_standard_derivatives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL: https://cvs.khronos.org/svn/repos/reg...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-26 16:03 PDT by Martin Robinson
Modified: 2012-06-05 16:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.18 KB, patch)
2012-05-29 17:21 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-05-26 16:03:24 PDT
This extension is required by the WebGL conformance tests and is necessary to run the WebGL water demo at http://madebyevan.com/webgl-water/.  We can add support via ANGLE.
Comment 1 Martin Robinson 2012-05-29 17:21:49 PDT
Created attachment 144653 [details]
Patch
Comment 2 Alejandro G. Castro 2012-05-30 02:35:59 PDT
Comment on attachment 144653 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2012-05-30 07:52:36 PDT
Comment on attachment 144653 [details]
Patch

Rejecting attachment 144653 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Alejandro G found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12815013
Comment 4 WebKit Review Bot 2012-06-05 16:12:41 PDT
Comment on attachment 144653 [details]
Patch

Clearing flags on attachment: 144653

Committed r119533: <http://trac.webkit.org/changeset/119533>
Comment 5 WebKit Review Bot 2012-06-05 16:12:47 PDT
All reviewed patches have been landed.  Closing bug.