Bug 87582 - When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
Summary: When pages are loaded from AppCache with DeferredLoading, willSendRequest() i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-26 15:04 PDT by Benjamin Poulain
Modified: 2012-05-29 10:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.23 KB, patch)
2012-05-26 15:42 PDT, Benjamin Poulain
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-05-26 15:04:31 PDT
When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called.

<rdar://problem/11476505>
Comment 1 Benjamin Poulain 2012-05-26 15:42:30 PDT
Created attachment 144208 [details]
Patch
Comment 2 Darin Adler 2012-05-26 16:55:41 PDT
Comment on attachment 144208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144208&action=review

> Source/WebCore/loader/MainResourceLoader.cpp:701
> +        ResourceRequest r(m_initialRequest);
> +        m_initialRequest = ResourceRequest();
> +        loadNow(r);

As long as you’re touching this code, it might be nice to use a word or words for the name rather than just a letter. I’d suggest initialRequest or request or localCopyOfRequest.
Comment 3 Benjamin Poulain 2012-05-27 14:32:06 PDT
Committed r118631: <http://trac.webkit.org/changeset/118631>
Comment 4 Darin Adler 2012-05-29 10:24:41 PDT
After a comment from Alexey I realize this strikes at the question of what “sending” a request is.