WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87582
When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
https://bugs.webkit.org/show_bug.cgi?id=87582
Summary
When pages are loaded from AppCache with DeferredLoading, willSendRequest() i...
Benjamin Poulain
Reported
2012-05-26 15:04:31 PDT
When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called. <
rdar://problem/11476505
>
Attachments
Patch
(14.23 KB, patch)
2012-05-26 15:42 PDT
,
Benjamin Poulain
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2012-05-26 15:42:30 PDT
Created
attachment 144208
[details]
Patch
Darin Adler
Comment 2
2012-05-26 16:55:41 PDT
Comment on
attachment 144208
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=144208&action=review
> Source/WebCore/loader/MainResourceLoader.cpp:701 > + ResourceRequest r(m_initialRequest); > + m_initialRequest = ResourceRequest(); > + loadNow(r);
As long as you’re touching this code, it might be nice to use a word or words for the name rather than just a letter. I’d suggest initialRequest or request or localCopyOfRequest.
Benjamin Poulain
Comment 3
2012-05-27 14:32:06 PDT
Committed
r118631
: <
http://trac.webkit.org/changeset/118631
>
Darin Adler
Comment 4
2012-05-29 10:24:41 PDT
After a comment from Alexey I realize this strikes at the question of what “sending” a request is.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug