Bug 87568 – [chromium] Unskip http/tests/media/video-buffered.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ami Fischman]

http/tests/media/video-buffered.html has been skipped in chromium since forever because chromium never reported correct buffered ranges (specifically, it never reported than a single, fake, range).
In 85926 chromium learned to report multiple ranges to JS, but still had a bug where any read from the end of the file (such as for a read index) would cause chromium to claim to have buffered the entire file.
https://chromiumcodereview.appspot.com/10451049/ fixes this, and once it lands chromium will report correct ranges even after seeking.  At that point this layouttest can be unskipped.

[Ami Fischman]

Created attachment 144193 [details]
Patch

[WebKit Review Bot]

Comment on attachment 144193 [details]
Patch

Attachment 144193 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12805697

New failing tests:
http/tests/media/video-buffered.html

[WebKit Review Bot]

Created attachment 144196 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ami Fischman]

ews failure is expected, since the chromium side fix isn't in yet.

[Ami Fischman]

Created attachment 144206 [details]
Patch

[Eric Carlson]

Comment on attachment 144206 [details]
Patch

This is a much better test now, thanks!

[WebKit Review Bot]

Comment on attachment 144206 [details]
Patch

Attachment 144206 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12805803

New failing tests:
http/tests/media/video-buffered.html

[WebKit Review Bot]

Created attachment 144209 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ami Fischman]

Created attachment 145004 [details]
Patch

[WebKit Review Bot]

Comment on attachment 145004 [details]
Patch

Rejecting attachment 145004 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12853846

[WebKit Review Bot]

Comment on attachment 145004 [details]
Patch

Attachment 145004 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12867204

New failing tests:
http/tests/media/video-buffered.html

[WebKit Review Bot]

Created attachment 145068 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ami Fischman]

Created attachment 145117 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 145117 [details]
Patch for landing

Rejecting attachment 145117 [details] from commit-queue.

New failing tests:
http/tests/media/video-buffered.html
Full output: http://queues.webkit.org/results/12870274

[WebKit Review Bot]

Created attachment 145150 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[WebKit Review Bot]

Comment on attachment 145117 [details]
Patch for landing

Attachment 145117 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12859528

New failing tests:
http/tests/media/video-buffered.html

[WebKit Review Bot]

Created attachment 145179 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ami Fischman]

Created attachment 145203 [details]
Patch

[WebKit Review Bot]

Comment on attachment 145203 [details]
Patch

Attachment 145203 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12864497

New failing tests:
http/tests/media/video-buffered.html

[WebKit Review Bot]

Created attachment 145239 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ami Fischman]

Created attachment 145337 [details]
Patch for landing

[Ami Fischman]

FTR, the CQ & EWS kept failing b/c they run in Release mode, but my desktop kept passing in Debug mode.  Building Release on my desktop repro'd the timeouts, and increasing the throttle rate made the timeouts go away (100% pass rate with 1000 iterations).

[WebKit Review Bot]

Comment on attachment 145337 [details]
Patch for landing

Clearing flags on attachment: 145337

Committed r119268: <http://trac.webkit.org/changeset/119268>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.