Bug 87568 - [chromium] Unskip http/tests/media/video-buffered.html
Summary: [chromium] Unskip http/tests/media/video-buffered.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-25 22:22 PDT by Ami Fischman
Modified: 2012-06-01 12:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.62 KB, patch)
2012-05-25 22:23 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (526.16 KB, application/zip)
2012-05-26 00:02 PDT, WebKit Review Bot
no flags Details
Patch (194.00 KB, patch)
2012-05-26 11:36 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (555.84 KB, application/zip)
2012-05-26 16:06 PDT, WebKit Review Bot
no flags Details
Patch (194.01 KB, patch)
2012-05-31 00:20 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (535.59 KB, application/zip)
2012-05-31 06:04 PDT, WebKit Review Bot
no flags Details
Patch for landing (193.97 KB, patch)
2012-05-31 11:14 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (463.35 KB, application/zip)
2012-05-31 13:54 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-01 (480.46 KB, application/zip)
2012-05-31 17:37 PDT, WebKit Review Bot
no flags Details
Patch (3.80 KB, patch)
2012-05-31 20:44 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-04 (451.25 KB, application/zip)
2012-06-01 01:29 PDT, WebKit Review Bot
no flags Details
Patch for landing (3.61 KB, patch)
2012-06-01 10:24 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ami Fischman 2012-05-25 22:22:42 PDT
http/tests/media/video-buffered.html has been skipped in chromium since forever because chromium never reported correct buffered ranges (specifically, it never reported than a single, fake, range).
In 85926 chromium learned to report multiple ranges to JS, but still had a bug where any read from the end of the file (such as for a read index) would cause chromium to claim to have buffered the entire file.
https://chromiumcodereview.appspot.com/10451049/ fixes this, and once it lands chromium will report correct ranges even after seeking.  At that point this layouttest can be unskipped.
Comment 1 Ami Fischman 2012-05-25 22:23:27 PDT
Created attachment 144193 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-26 00:02:06 PDT
Comment on attachment 144193 [details]
Patch

Attachment 144193 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12805697

New failing tests:
http/tests/media/video-buffered.html
Comment 3 WebKit Review Bot 2012-05-26 00:02:09 PDT
Created attachment 144196 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Ami Fischman 2012-05-26 00:48:26 PDT
ews failure is expected, since the chromium side fix isn't in yet.
Comment 5 Ami Fischman 2012-05-26 11:36:33 PDT
Created attachment 144206 [details]
Patch
Comment 6 Eric Carlson 2012-05-26 11:46:30 PDT
Comment on attachment 144206 [details]
Patch

This is a much better test now, thanks!
Comment 7 WebKit Review Bot 2012-05-26 16:06:21 PDT
Comment on attachment 144206 [details]
Patch

Attachment 144206 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12805803

New failing tests:
http/tests/media/video-buffered.html
Comment 8 WebKit Review Bot 2012-05-26 16:06:24 PDT
Created attachment 144209 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 9 Ami Fischman 2012-05-31 00:20:56 PDT
Created attachment 145004 [details]
Patch
Comment 10 WebKit Review Bot 2012-05-31 00:25:33 PDT
Comment on attachment 145004 [details]
Patch

Rejecting attachment 145004 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12853846
Comment 11 WebKit Review Bot 2012-05-31 06:04:17 PDT
Comment on attachment 145004 [details]
Patch

Attachment 145004 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12867204

New failing tests:
http/tests/media/video-buffered.html
Comment 12 WebKit Review Bot 2012-05-31 06:04:21 PDT
Created attachment 145068 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 13 Ami Fischman 2012-05-31 11:14:14 PDT
Created attachment 145117 [details]
Patch for landing
Comment 14 WebKit Review Bot 2012-05-31 13:54:05 PDT
Comment on attachment 145117 [details]
Patch for landing

Rejecting attachment 145117 [details] from commit-queue.

New failing tests:
http/tests/media/video-buffered.html
Full output: http://queues.webkit.org/results/12870274
Comment 15 WebKit Review Bot 2012-05-31 13:54:09 PDT
Created attachment 145150 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 16 WebKit Review Bot 2012-05-31 17:36:57 PDT
Comment on attachment 145117 [details]
Patch for landing

Attachment 145117 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12859528

New failing tests:
http/tests/media/video-buffered.html
Comment 17 WebKit Review Bot 2012-05-31 17:37:00 PDT
Created attachment 145179 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 18 Ami Fischman 2012-05-31 20:44:38 PDT
Created attachment 145203 [details]
Patch
Comment 19 WebKit Review Bot 2012-06-01 01:28:57 PDT
Comment on attachment 145203 [details]
Patch

Attachment 145203 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12864497

New failing tests:
http/tests/media/video-buffered.html
Comment 20 WebKit Review Bot 2012-06-01 01:29:00 PDT
Created attachment 145239 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 21 Ami Fischman 2012-06-01 10:24:49 PDT
Created attachment 145337 [details]
Patch for landing
Comment 22 Ami Fischman 2012-06-01 10:29:20 PDT
FTR, the CQ & EWS kept failing b/c they run in Release mode, but my desktop kept passing in Debug mode.  Building Release on my desktop repro'd the timeouts, and increasing the throttle rate made the timeouts go away (100% pass rate with 1000 iterations).
Comment 23 WebKit Review Bot 2012-06-01 12:58:37 PDT
Comment on attachment 145337 [details]
Patch for landing

Clearing flags on attachment: 145337

Committed r119268: <http://trac.webkit.org/changeset/119268>
Comment 24 WebKit Review Bot 2012-06-01 12:58:43 PDT
All reviewed patches have been landed.  Closing bug.