Bug 87566 – [BlackBerry] Add a constructor to create a Path from an SkPath

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Arvid Nilsson]

commit 00ee90cf093e9004e08e7b4970b5c84be263a295
Author: Arvid Nilsson <[e-mail]>
Date:   Fri May 4 00:20:05 2012 +0200

    2012-05-03  Arvid Nilsson  <[e-mail]>
    
            Add a constructor to create a Path from an SkPath
            PR #154329
    
            Skia allows the creation of more complex paths than WebCore would
            allow. This will be used in the BlackBerry port to implement a default
            tap highlight appearance.
    
            Reviewed by Mike Lattanzio.
    
            * platform/graphics/Path.h:
            (Path):
            * platform/graphics/skia/PathSkia.cpp:
            (WebCore::Path::Path):
            (WebCore):

[Arvid Nilsson]

Created attachment 144229 [details]
Patch

[Antonio Gomes]

Comment on attachment 144229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144229&action=review

r+, but lets fix one think before landing: when reuploading, please pre-fill "Reviewed by Antonio Gomes" and just set cq?

> Source/WebCore/platform/graphics/Path.h:162
> +#if PLATFORM(BLACKBERRY) && USE(SKIA)

I would drop the use(skia) here.

[Arvid Nilsson]

Created attachment 144237 [details]
Patch

[WebKit Review Bot]

Comment on attachment 144237 [details]
Patch

Clearing flags on attachment: 144237

Committed r118682: <http://trac.webkit.org/changeset/118682>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.