Bug 87549 - weakCompareAndSwap should work on Windows
Summary: weakCompareAndSwap should work on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-25 16:43 PDT by Filip Pizlo
Modified: 2012-05-26 17:16 PDT (History)
2 users (show)

See Also:

Attachments
the patch (1.70 KB, patch)
2012-05-25 16:45 PDT, Filip Pizlo 		jberlin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
attempt to actually make it build (1.78 KB, patch)
2012-05-25 17:11 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-05-25 16:43:24 PDT 
By using the InterlockedCompareExchange function.
Comment 1 Filip Pizlo 2012-05-25 16:45:02 PDT 
Created attachment 144170 [details]
the patch
Comment 2 Jessie Berlin 2012-05-25 16:51:02 PDT 
Comment on attachment 144170 [details]
the patch

r=me (assuming this passes win EWS)
Comment 3 Filip Pizlo 2012-05-25 16:52:00 PDT 
(In reply to comment #2)
> (From update of attachment 144170 [details])
> r=me (assuming this passes win EWS)

Thanks!  Will await the greenness.
Comment 4 Build Bot 2012-05-25 17:07:13 PDT 
Comment on attachment 144170 [details]
the patch

Attachment 144170 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12801605
Comment 5 Filip Pizlo 2012-05-25 17:11:20 PDT 
Created attachment 144174 [details]
attempt to actually make it build
Comment 6 WebKit Review Bot 2012-05-25 20:09:52 PDT 
Comment on attachment 144174 [details]
attempt to actually make it build

Clearing flags on attachment: 144174

Committed r118603: <http://trac.webkit.org/changeset/118603>
Comment 7 WebKit Review Bot 2012-05-25 20:09:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2012-05-26 17:16:17 PDT 
Comment on attachment 144170 [details]
the patch

Windows EWS says:

2>c:\cygwin\home\buildbot\WebKit\Source\WTF\wtf/Atomics.h(124) : error C2664: 'InterlockedCompareExchange' : cannot convert parameter 1 from 'volatile unsigned int *' to 'volatile LONG *'

Thus, I suspect we have a need for some type casting.
Comment 9 Darin Adler 2012-05-26 17:16:34 PDT 
Oh, I see that was fixed before landing.