Support building the Android port of chromium with Ninja
Created attachment 144165 [details] Patch
Attachment 144165 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Looks like you've got some tabs in your ChangeLog. This looks plausible to me, but I don't actually know how this all works. Hopefully thakis can help. :)
LGTM. I'm not a fan of the ant_build_dir, but that's how android's doing it in chromium land too.
Created attachment 144167 [details] Patch
Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit?
> Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit? Once your change lands in Chromium, you just need to edit this revision number: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35 We typically just bump the number in a separate commit as needed. It usually goes smoothly, but if you have and trouble, feel free to ping me and we'll figure it out.
While I was doing something else, looks like other folks already rolled DEPS past my revision. Seems like this is ready to go.
I'm not a committer, though. Adam can you put it in the CQ?
Comment on attachment 144167 [details] Patch Clearing flags on attachment: 144167 Committed r119183: <http://trac.webkit.org/changeset/119183>
All reviewed patches have been landed. Closing bug.