Bug 87536 - REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
Summary: REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-25 14:33 PDT by Julien Chaffraix
Modified: 2012-05-31 11:49 PDT (History)
5 users (show)

See Also:


Attachments
Test case: the rows should be 100px wide, not 120px (583 bytes, text/html)
2012-05-25 14:33 PDT, Julien Chaffraix
no flags Details
Proposed fix. Take into account the box-sizing when computing the cell's size, refactored the code as we go. (18.67 KB, patch)
2012-05-25 16:39 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Proposed fix (ct'd). Take into account the box-sizing when computing the cell's size, refactored the code as we go. (18.59 KB, patch)
2012-05-25 16:51 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-05-25 14:33:45 PDT
Created attachment 144148 [details]
Test case: the rows should be 100px wide, not 120px

During the review of bug 78412, box-sizing interaction was mentioned but unfortunately the patch went in without this being tested in any way.

This is unfortunate as box-sizing: border-box was the way to mitigate the web-compatibility issue from the original change: it make us correctly interpret width per CSS 2.1 but in an incompatible manner.
Comment 1 Julien Chaffraix 2012-05-25 16:39:00 PDT
Created attachment 144169 [details]
Proposed fix. Take into account the box-sizing when computing the cell's size, refactored the code as we go.
Comment 2 Julien Chaffraix 2012-05-25 16:51:22 PDT
Created attachment 144171 [details]
Proposed fix (ct'd). Take into account the box-sizing when computing the cell's size, refactored the code as we go.
Comment 3 Julien Chaffraix 2012-05-29 11:32:01 PDT
Comment on attachment 144171 [details]
Proposed fix (ct'd). Take into account the box-sizing when computing the cell's size, refactored the code as we go.

Thanks Tony!
Comment 4 WebKit Review Bot 2012-05-29 12:31:01 PDT
Comment on attachment 144171 [details]
Proposed fix (ct'd). Take into account the box-sizing when computing the cell's size, refactored the code as we go.

Clearing flags on attachment: 144171

Committed r118819: <http://trac.webkit.org/changeset/118819>
Comment 5 WebKit Review Bot 2012-05-29 12:31:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Andy Estes 2012-05-31 11:49:38 PDT
<rdar://problem/11567612>