[Chromium] Move fileExists to Platform.h
Created attachment 144135 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Attachment 144135 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 144137 [details] Patch
Comment on attachment 144137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144137&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:-305 > -bool PlatformSupport::fileExists(const String& path) Should we remove this from PlatformSupport.h as well?
Created attachment 144601 [details] Patch
Latest patch removes function declaration from PlatformSupport.h.
Comment on attachment 144601 [details] Patch Clearing flags on attachment: 144601 Committed r118873: <http://trac.webkit.org/changeset/118873>
All reviewed patches have been landed. Closing bug.
Reopening per discussion with abarth in IRC.
Created attachment 144682 [details] Followup patch
Comment on attachment 144682 [details] Followup patch Call fileExists through fileUtilities(), not directly.
Comment on attachment 144682 [details] Followup patch Clearing flags on attachment: 144682 Committed r118894: <http://trac.webkit.org/changeset/118894>