Bug 87531 - [Chromium] Move fileExists to Platform.h
Summary: [Chromium] Move fileExists to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-05-25 13:14 PDT by Mark Pilgrim (Google)
Modified: 2012-05-29 22:10 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2012-05-25 13:14 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2012-05-25 13:18 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (4.74 KB, patch)
2012-05-29 12:33 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Followup patch (2.51 KB, patch)
2012-05-29 19:40 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-25 13:14:02 PDT 
[Chromium] Move fileExists to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-25 13:14:50 PDT 
Created attachment 144135 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-25 13:16:37 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-05-25 13:16:55 PDT 
Attachment 144135 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Pilgrim (Google) 2012-05-25 13:18:25 PDT 
Created attachment 144137 [details]
Patch
Comment 5 Adam Barth 2012-05-25 16:10:03 PDT 
Comment on attachment 144137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144137&action=review

> Source/WebKit/chromium/src/PlatformSupport.cpp:-305
> -bool PlatformSupport::fileExists(const String& path)

Should we remove this from PlatformSupport.h as well?
Comment 6 Mark Pilgrim (Google) 2012-05-29 12:33:28 PDT 
Created attachment 144601 [details]
Patch
Comment 7 Mark Pilgrim (Google) 2012-05-29 12:43:53 PDT 
Latest patch removes function declaration from PlatformSupport.h.
Comment 8 WebKit Review Bot 2012-05-29 18:34:08 PDT 
Comment on attachment 144601 [details]
Patch

Clearing flags on attachment: 144601

Committed r118873: <http://trac.webkit.org/changeset/118873>
Comment 9 WebKit Review Bot 2012-05-29 18:34:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Mark Pilgrim (Google) 2012-05-29 19:33:20 PDT 
Reopening per discussion with abarth in IRC.
Comment 11 Mark Pilgrim (Google) 2012-05-29 19:40:24 PDT 
Created attachment 144682 [details]
Followup patch
Comment 12 Mark Pilgrim (Google) 2012-05-29 19:42:02 PDT 
Comment on attachment 144682 [details]
Followup patch

Call fileExists through fileUtilities(), not directly.
Comment 13 WebKit Review Bot 2012-05-29 22:10:52 PDT 
Comment on attachment 144682 [details]
Followup patch

Clearing flags on attachment: 144682

Committed r118894: <http://trac.webkit.org/changeset/118894>
Comment 14 WebKit Review Bot 2012-05-29 22:10:58 PDT 
All reviewed patches have been landed.  Closing bug.