Bug 87523 - Make RenderLayer not arena-allocated
Summary: Make RenderLayer not arena-allocated
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 122651
  Show dependency treegraph
Reported: 2012-05-25 11:42 PDT by Simon Fraser (smfr)
Modified: 2013-10-12 02:14 PDT (History)
10 users (show)

See Also:

Patch (4.96 KB, patch)
2013-10-11 01:14 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-05-25 11:42:06 PDT
We don't think we're getting any benefit from RenderLayer being arena-allocated, and it adds code complexity.
Comment 1 Eric Seidel (no email) 2012-05-25 12:12:04 PDT
Comment 2 Ojan Vafai 2012-05-25 12:21:19 PDT
How is RenderLayer different than the other Render* classes WRT usefulness of being arena-allocated?
Comment 3 Simon Fraser (smfr) 2012-05-25 12:47:00 PDT
There don't tend to be that many RenderLayers on most pages (tens - hundreds, not thousands).
Comment 4 Ojan Vafai 2012-05-25 13:03:17 PDT
Fair enough.
Comment 5 Andreas Kling 2013-10-11 01:14:29 PDT
Created attachment 213975 [details]
Comment 6 WebKit Commit Bot 2013-10-11 02:37:57 PDT
Comment on attachment 213975 [details]

Clearing flags on attachment: 213975

Committed r157297: <http://trac.webkit.org/changeset/157297>
Comment 7 WebKit Commit Bot 2013-10-11 02:37:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2013-10-11 09:49:08 PDT
Re-opened since this is blocked by bug 122651
Comment 9 Alexey Proskuryakov 2013-10-11 09:53:46 PDT
This caused crashes on tests (debug and release WK2). Very strange that EWS didn't catch it, was the landed patch identical to the one posted here?

Rolled out in <https://trac.webkit.org/r157306>. Results:

Comment 10 Andreas Kling 2013-10-12 02:14:09 PDT
Committed r157333: <http://trac.webkit.org/changeset/157333>