Bug 87520 (log) - add a new logging channel for MediaStream
Summary: add a new logging channel for MediaStream
Status: RESOLVED WONTFIX
Alias: log
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 87514
  Show dependency tree / graph
 
Reported: 2012-05-25 11:26 PDT by Danilo de Paula
Modified: 2013-09-06 10:16 PDT (History)
5 users (show)

See Also:

Attachments
patch proposal (2.68 KB, patch)
2012-05-25 11:36 PDT, Danilo de Paula 		buildbot: commit-queue-
Details | Formatted Diff | Diff
patch proposal (2.75 KB, patch)
2012-05-25 13:04 PDT, Danilo de Paula 		pnormand: review-
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo de Paula 2012-05-25 11:26:44 PDT 
Since MediaStream components produce a lot of useful debug information, would be nice to create its own log channel.
Comment 1 Danilo de Paula 2012-05-25 11:36:36 PDT 
Created attachment 144108 [details]
patch proposal
Comment 2 WebKit Review Bot 2012-05-25 11:39:32 PDT 
Attachment 144108 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-05-25 11:52:46 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12791589
Comment 4 Build Bot 2012-05-25 11:52:55 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12795592
Comment 5 Early Warning System Bot 2012-05-25 11:57:49 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12792573
Comment 6 Early Warning System Bot 2012-05-25 12:05:21 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12795596
Comment 7 Gyuyoung Kim 2012-05-25 12:28:34 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12802519
Comment 8 WebKit Review Bot 2012-05-25 12:33:56 PDT 
Comment on attachment 144108 [details]
patch proposal

Attachment 144108 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12794573
Comment 9 Danilo de Paula 2012-05-25 13:04:43 PDT 
Created attachment 144134 [details]
patch proposal

Fixing a small issue.
Comment 10 Danilo de Paula 2012-05-25 13:12:24 PDT 
I will push a few dependencies to this bug (using this log channel) in the next hours.
Comment 11 WebKit Review Bot 2012-09-19 07:04:48 PDT 
Comment on attachment 144134 [details]
patch proposal

Rejecting attachment 144134 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13891579
Comment 12 Philippe Normand 2012-09-19 07:09:06 PDT 
Comment on attachment 144134 [details]
patch proposal

Reviewed by field is missing indeed
Comment 13 Danilo de Paula 2012-09-19 07:33:17 PDT 
It seems that all the logging addresses bits are being used now.

any idea on what should we do on that case?
Comment 14 Danilo de Paula 2013-09-06 10:16:20 PDT 
not necessary anymore