Bug 87519 – Turn on Regions for Apple Windows port

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tim Horton]

After http://trac.webkit.org/changeset/118484

[Radar WebKit Bug Importer]

<rdar://problem/11535700>

[Tim Horton]

Created attachment 144107 [details]
patch

[Tim Horton]

O...kay...

7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(287) : error C2065: 'CSSPropertyWebkitShapeInside' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(288) : error C2065: 'CSSPropertyWebkitShapeOutside' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(315) : error C2065: 'CSSPropertyWebkitFlowInto' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(316) : error C2065: 'CSSPropertyWebkitFlowFrom' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(317) : error C2065: 'CSSPropertyWebkitRegionOverflow' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(318) : error C2065: 'CSSPropertyWebkitRegionBreakAfter' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(319) : error C2065: 'CSSPropertyWebkitRegionBreakBefore' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(320) : error C2065: 'CSSPropertyWebkitRegionBreakInside' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(323) : error C2065: 'CSSPropertyWebkitWrapFlow' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(324) : error C2065: 'CSSPropertyWebkitWrapMargin' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(325) : error C2065: 'CSSPropertyWebkitWrapPadding' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(326) : error C2065: 'CSSPropertyWebkitWrapThrough' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1601) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1603) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1605) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2324) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2328) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2332) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2336) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2338) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2340) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2342) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2346) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2350) : error C2051: case expression not constant
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2484) : error C2065: 'CSSPropertyWebkitWrap' : undeclared identifier
7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2484) : error C2051: case expression not constant

[Build Bot]

Comment on attachment 144107 [details]
patch

Attachment 144107 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12802509

[Tim Horton]

I get very similar errors if I flip the setting and don't do a clean build on mac. I'll have to manually verify this at some point, probably not today.

[Tim Horton]

*** This bug has been marked as a duplicate of bug 88645 ***

[Roger Fong]

Created attachment 194918 [details]
patch

[Tim Horton]

Comment on attachment 194918 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194918&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:13813
>  			<File
> -				RelativePath="$(ConfigurationBuildDir)\obj\WebCore\DerivedSources\JSShadowRoot.cpp"
> +				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSecurityPolicyViolationEvent.cpp"
>  				>
>  				<FileConfiguration
>  					Name="Debug|Win32"

This looks unexpected.

[WebKit Review Bot]

Re-opened since this is blocked by bug 113262

[Mihai Balan]

There is a Windows port no more :)

[Roger Fong]

There is a windows port...we're maintaining it

[Zoltan Horvath]

Removing Exclusions/Shapes from the bug title, since it's been enabled in http://trac.webkit.org/changeset/160200

[Brent Fulgham]

All of this is on an active in Windows.