RESOLVED FIXED 87512
Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors. 
https://bugs.webkit.org/show_bug.cgi?id=87512
Summary Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptS...
Vsevolod Vlasov
Reported 2012-05-25 10:41:44 PDT
Patch to follow
Attachments
Patch (21.81 KB, patch)
2012-05-25 10:44 PDT, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-05-25 10:44:41 PDT
Created attachment 144099 [details] Patch
Vsevolod Vlasov
Comment 2 2012-05-25 10:45:11 PDT
This might need some polish before landing, but overall, folks, what do you think?
WebKit Review Bot
Comment 3 2012-05-25 10:47:04 PDT
Attachment 144099 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/generate_protocol_externs.py:7: trailing whitespace [pep8/W291] [5] Source/WebCore/inspector/generate_protocol_externs.py:17: trailing whitespace [pep8/W291] [5] Source/WebCore/inspector/generate_protocol_externs.py:37: whitespace before '}' [pep8/E202] [5] Source/WebCore/inspector/generate_protocol_externs.py:42: expected 2 blank lines, found 1 [pep8/E302] [5] Source/WebCore/inspector/generate_protocol_externs.py:44: indentation is not a multiple of four [pep8/E111] [5] Source/WebCore/inspector/generate_protocol_externs.py:46: trailing whitespace [pep8/W291] [5] Source/WebCore/inspector/generate_protocol_externs.py:47: expected 2 blank lines, found 1 [pep8/E302] [5] Source/WebCore/inspector/generate_protocol_externs.py:62: expected 2 blank lines, found 1 [pep8/E302] [5] Source/WebCore/inspector/generate_protocol_externs.py:72: whitespace before ')' [pep8/E202] [5] Source/WebCore/inspector/generate_protocol_externs.py:130: multiple statements on one line (semicolon) [pep8/E702] [5] Source/WebCore/inspector/generate_protocol_externs.py:150: multiple statements on one line (semicolon) [pep8/E702] [5] Source/WebCore/inspector/generate_protocol_externs.py:152: multiple statements on one line (semicolon) [pep8/E702] [5] Total errors found: 12 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yury Semikhatsky
Comment 4 2012-05-27 23:26:36 PDT
Comment on attachment 144099 [details] Patch Looks good.
Yury Semikhatsky
Comment 5 2012-05-27 23:27:29 PDT
(In reply to comment #4) > (From update of attachment 144099 [details]) > Looks good. Please fix style warnings before landing.
Vsevolod Vlasov
Comment 6 2012-06-06 04:37:17 PDT
Committed r119585: <http://trac.webkit.org/changeset/119585>
Note You need to log in before you can comment on or make changes to this bug.