RESOLVED FIXED 87502
Web Inspector: speed-up HeapSnapshot._bfs method. 
https://bugs.webkit.org/show_bug.cgi?id=87502
Summary Web Inspector: speed-up HeapSnapshot._bfs method.
Ilya Tikhonovsky
Reported 2012-05-25 07:59:52 PDT
it had containmentEdges.length call in the loop. before RESULT heap-snapshot: _calculateObjectToWindowDistance= 117 ms after RESULT heap-snapshot: _calculateObjectToWindowDistance= 36 ms
Attachments
Patch (4.27 KB, patch)
2012-05-25 08:01 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-25 08:01:46 PDT
Created attachment 144069 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-25 08:31:20 PDT
Comment on attachment 144069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144069&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:934 > + nodesToVisit[nodesToVisitLength++] = childNodeIndex; Please add an assert that nodesToVisitLength <= this.nodeCount
Ilya Tikhonovsky
Comment 3 2012-05-25 08:41:09 PDT
Committed r118529: <http://trac.webkit.org/changeset/118529>
Note You need to log in before you can comment on or make changes to this bug.