Bug 87493 - [Shadow DOM] ComposedShadowTreeWalker assumes a shadowRoot is always assigned to an insertion point.
Summary: [Shadow DOM] ComposedShadowTreeWalker assumes a shadowRoot is always assigned...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 78585 87924
  Show dependency tree / graph
 
Reported: 2012-05-25 05:16 PDT by Hayato Ito
Modified: 2012-05-31 00:55 PDT (History)
6 users (show)

See Also:

Attachments
support an orphaned shadow subtree (8.53 KB, patch)
2012-05-30 21:11 PDT, Hayato Ito 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-05-25 05:16:05 PDT 
ComposedShadowTreeWalker assumes a shadowRoot is always assigned to an insertion point.
In most use cases, this assumption is correct since ComposedShadowTreeWalker traverses nodes which are rendered.

But there is an exception. One is event dispatching. A node in a orphaned shadow root can receive events, such as 'click' event.
So ComposedShadowTreeWalker must handle such cases.
Comment 1 Hayato Ito 2012-05-30 21:11:38 PDT 
Created attachment 144981 [details]
support an orphaned shadow subtree
Comment 2 WebKit Review Bot 2012-05-31 00:55:47 PDT 
Comment on attachment 144981 [details]
support an orphaned shadow subtree

Clearing flags on attachment: 144981

Committed r119069: <http://trac.webkit.org/changeset/119069>
Comment 3 WebKit Review Bot 2012-05-31 00:55:52 PDT 
All reviewed patches have been landed.  Closing bug.