Bug 87490 - Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric
Summary: Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-25 04:53 PDT by Ilya Tikhonovsky
Modified: 2012-05-25 06:42 PDT (History)
15 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2012-05-25 04:57 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-05-25 04:53:08 PDT 
Originally WebInspector.Uint32Array was used for dynamic array
reallocation because we had no information about expected arrays sizes.
Now we have these sizes and allocates array precisely.
Comment 1 Ilya Tikhonovsky 2012-05-25 04:55:05 PDT 
before:
RESULT heap-snapshot: transfer-snapshot= 1809 ms

after:
RESULT heap-snapshot: transfer-snapshot= 1530 ms
Comment 2 Ilya Tikhonovsky 2012-05-25 04:57:34 PDT 
Created attachment 144046 [details]
Patch
Comment 3 Yury Semikhatsky 2012-05-25 05:01:11 PDT 
Comment on attachment 144046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144046&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:156
>              var node_fields_count = this._snapshot.snapshot.meta.node_fields.length;

node_fields_count -> nodeFieldCount

> Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:157
>              var nodes_length = this._snapshot.snapshot.node_count * node_fields_count;

nodes_length -> nodeLength
Comment 4 Ilya Tikhonovsky 2012-05-25 06:42:56 PDT 
Committed r118521: <http://trac.webkit.org/changeset/118521>