Bug 87471 - [EFL][DRT] Gardening. fast/events/option-tab.html does not pass
Summary: [EFL][DRT] Gardening. fast/events/option-tab.html does not pass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-25 01:20 PDT by Mikhail Pozdnyakov
Modified: 2012-05-25 02:41 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.58 KB, patch)
2012-05-25 01:25 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (corrected bug title in changelog) (1.58 KB, patch)
2012-05-25 01:36 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-05-25 01:20:58 PDT 
fast/events/option-tab.html was erroneously unskipped with r118404.
Should not pass as the EFL port uses different keyboard accelerators than Safari.
Comment 1 Mikhail Pozdnyakov 2012-05-25 01:25:18 PDT 
Created attachment 144003 [details]
patch
Comment 2 Thiago Marcos P. Santos 2012-05-25 01:28:46 PDT 
(In reply to comment #1)
> Created an attachment (id=144003) [details]
> patch

Why this patch was tagged as [GTK]?
Comment 3 Mikhail Pozdnyakov 2012-05-25 01:29:30 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=144003) [details] [details]
> > patch
> 
> Why this patch was tagged as [GTK]?

ooops..
Comment 4 Thiago Marcos P. Santos 2012-05-25 01:31:21 PDT 
Comment on attachment 144003 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review

> LayoutTests/platform/efl/test_expectations.txt:115
> +// The EFL port uses different keyboard accelerators than Safari (via Chromium).

I don't get this comment.
Comment 5 Mikhail Pozdnyakov 2012-05-25 01:36:24 PDT 
Created attachment 144005 [details]
patch v2 (corrected bug title in changelog)
Comment 6 Mikhail Pozdnyakov 2012-05-25 01:56:10 PDT 
(In reply to comment #4)
> (From update of attachment 144003 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review
> 
> > LayoutTests/platform/efl/test_expectations.txt:115
> > +// The EFL port uses different keyboard accelerators than Safari (via Chromium).
> 
> I don't get this comment.

From the test case description:
<p>This tests that option-tab moves you from a text field to a link, but plain old tab does not.</p>
<p>Note: Option is the Mac name for what other platforms call Alt.</p>

Other platforms do not have such behavior. (See also other ports test expectations).
Comment 7 WebKit Review Bot 2012-05-25 02:41:31 PDT 
Comment on attachment 144005 [details]
patch v2 (corrected bug title in changelog)

Clearing flags on attachment: 144005

Committed r118502: <http://trac.webkit.org/changeset/118502>
Comment 8 WebKit Review Bot 2012-05-25 02:41:36 PDT 
All reviewed patches have been landed.  Closing bug.