The current implementation (WebCore::EventDispatcher::ensureEventAncestors) does not set event's target correctly if it is applied to multiple shadow roots. Let me upload a test case and a fix soon.
Created attachment 144014 [details] fix an event re-target to support multiple shadow roots
I feed bad that shadow-dom-event-dispatching.html has badly-named functions. It has functions from 'prepareDOMTree1' to 'prepareDOMTree8'... I filed that as another bug. https://bugs.webkit.org/show_bug.cgi?id=87477 I also think that current shadow DOM spec should be slightly modified. Let me file it later.
I filed a bug for the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=17177 (In reply to comment #2) > I feed bad that shadow-dom-event-dispatching.html has badly-named functions. > It has functions from 'prepareDOMTree1' to 'prepareDOMTree8'... > > I filed that as another bug. https://bugs.webkit.org/show_bug.cgi?id=87477 > > I also think that current shadow DOM spec should be slightly modified. Let me file it later.
Comment on attachment 144014 [details] fix an event re-target to support multiple shadow roots Attachment 144014 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12791482 New failing tests: svg/custom/use-elementInstance-methods.svg svg/custom/use-elementInstance-event-target.svg svg/custom/use-instanceRoot-as-event-target.xhtml svg/custom/use-instanceRoot-event-bubbling.xhtml
Created attachment 144026 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 144030 [details] fix svg errors
Comment on attachment 144030 [details] fix svg errors Good catch and much cleaner resulting code. Please consider adding anime to your tests.
Thank you for the review. (In reply to comment #7) > (From update of attachment 144030 [details]) > Good catch and much cleaner resulting code. Please consider adding anime to your tests. It's more difficult for me to add anime characters than to fix crash bugs. Any suggestions for anime characters are highly welcome.
Comment on attachment 144030 [details] fix svg errors Rejecting attachment 144030 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12850037
Created attachment 144259 [details] Patch for landing
Comment on attachment 144259 [details] Patch for landing Clearing flags on attachment: 144259 Committed r118645: <http://trac.webkit.org/changeset/118645>
All reviewed patches have been landed. Closing bug.