Bug 87462 – Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Luke Macpherson]

Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.

[Luke Macpherson]

Created attachment 143977 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 143977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143977&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:70
> +    if (m_type != UnknownTransformOperation) {

Do we need to ASSERT the expected range of m_type somewhere around here?

[Luke Macpherson]

Created attachment 144254 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 144254 [details]
Patch for landing

Clearing flags on attachment: 144254

Committed r118639: <http://trac.webkit.org/changeset/118639>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 144254 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> +const int transformNameSize = 22;

Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us.

> Source/WebCore/css/WebKitCSSTransformValue.cpp:38
> +     "",

Why "" instead of 0 here?

[Luke Macpherson]

(In reply to comment #6)
> (From update of attachment 144254 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review
> 
> > Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> > +const int transformNameSize = 22;
> 
> Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us.
> 
> > Source/WebCore/css/WebKitCSSTransformValue.cpp:38
> > +     "",
> 
> Why "" instead of 0 here?

Fair points, I'll post a follow-up patch.