Bug 87462 - Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
Summary: Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks: 85580
  Show dependency tree / graph
 
Reported: 2012-05-24 22:23 PDT by Luke Macpherson
Modified: 2012-05-27 22:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2012-05-24 22:27 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (4.85 KB, patch)
2012-05-27 17:17 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-05-24 22:23:45 PDT 
Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
Comment 1 Luke Macpherson 2012-05-24 22:27:38 PDT 
Created attachment 143977 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-05-25 08:58:01 PDT 
Comment on attachment 143977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143977&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:70
> +    if (m_type != UnknownTransformOperation) {

Do we need to ASSERT the expected range of m_type somewhere around here?
Comment 3 Luke Macpherson 2012-05-27 17:17:43 PDT 
Created attachment 144254 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-05-27 18:53:35 PDT 
Comment on attachment 144254 [details]
Patch for landing

Clearing flags on attachment: 144254

Committed r118639: <http://trac.webkit.org/changeset/118639>
Comment 5 WebKit Review Bot 2012-05-27 18:53:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2012-05-27 20:39:27 PDT 
Comment on attachment 144254 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review

> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> +const int transformNameSize = 22;

Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us.

> Source/WebCore/css/WebKitCSSTransformValue.cpp:38
> +     "",

Why "" instead of 0 here?
Comment 7 Luke Macpherson 2012-05-27 22:00:21 PDT 
(In reply to comment #6)
> (From update of attachment 144254 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review
> 
> > Source/WebCore/css/WebKitCSSTransformValue.cpp:36
> > +const int transformNameSize = 22;
> 
> Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us.
> 
> > Source/WebCore/css/WebKitCSSTransformValue.cpp:38
> > +     "",
> 
> Why "" instead of 0 here?

Fair points, I'll post a follow-up patch.