Bug 87442 - Add feature defines for web-facing parts of CSS Regions and Exclusions
Summary: Add feature defines for web-facing parts of CSS Regions and Exclusions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-24 17:03 PDT by Tim Horton
Modified: 2012-05-25 01:45 PDT (History)
11 users (show)

See Also:

Attachments
patch (66.48 KB, patch)
2012-05-24 17:57 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (66.64 KB, patch)
2012-05-24 18:00 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (66.95 KB, patch)
2012-05-24 18:17 PDT, Tim Horton 		mitz: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing if windows builds (67.53 KB, patch)
2012-05-24 20:02 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
gtk (69.80 KB, patch)
2012-05-24 20:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-05-24 17:03:38 PDT 
The runtime flag and setting for Regions and Exclusions are insufficient to actually disable all web-facing aspects of these features.

<rdar://problem/10887709>
Comment 1 Tim Horton 2012-05-24 17:57:34 PDT 
Created attachment 143939 [details]
patch
Comment 2 Tim Horton 2012-05-24 18:00:36 PDT 
Created attachment 143940 [details]
patch
Comment 3 Tim Horton 2012-05-24 18:07:17 PDT 
Rebase time.
Comment 4 Tim Horton 2012-05-24 18:17:25 PDT 
Created attachment 143943 [details]
patch
Comment 5 Build Bot 2012-05-24 18:48:45 PDT 
Comment on attachment 143943 [details]
patch

Attachment 143943 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12798350
Comment 6 mitz 2012-05-24 18:59:31 PDT 
Comment on attachment 143943 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143943&action=review

r+ but you need to figure out why this is breaking Windows

> Source/WebCore/ChangeLog:9
> +        No new tests.

Either explain why there are no new tests, if you think it’s necessary, or just remove this line. If no tests are listed here, then there are no new tests!

> Source/WebCore/bindings/objc/DOMCSS.mm:55
> +#if ENABLE(CSS_REGIONS)
>  #import "DOMWebKitCSSRegionRule.h"
> +#endif

We don’t stick #if directives into the main #import or #include block. You should create a separate section with just this #import. This comment applies to the rest of this patch.
Comment 7 Tim Horton 2012-05-24 20:02:39 PDT 
Created attachment 143954 [details]
patch for landing if windows builds
Comment 8 Tim Horton 2012-05-24 20:20:40 PDT 
Created attachment 143957 [details]
gtk
Comment 9 Tim Horton 2012-05-24 23:54:09 PDT 
Landed in http://trac.webkit.org/changeset/118484
Comment 10 Csaba Osztrogonác 2012-05-25 01:45:35 PDT 
(In reply to comment #9)
> Landed in http://trac.webkit.org/changeset/118484

Enabled on Qt again: http://trac.webkit.org/changeset/118494