Bug 87438 - [BlackBerry] History navigation caused google.com scale not kept
Summary: [BlackBerry] History navigation caused google.com scale not kept
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 16:34 PDT by Jacky Jiang
Modified: 2012-05-25 08:55 PDT (History)
4 users (show)

See Also:


Attachments
committed, r=tonikitoo (3.30 KB, patch)
2012-05-24 18:06 PDT, Jacky Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2012-05-24 16:34:40 PDT
Steps to reproduce:
1) Open google.com.
2) navigate to poster circle (http://www.webkit.org/blog-files/3d-transforms/poster-circle.html).
3) click back button to go back to google.

Expected:
4) Google renders same size as on initial load.

Actual:
4) Google renders at the initial scale of poster circle (1.347).
Comment 1 Jacky Jiang 2012-05-24 18:06:33 PDT
Created attachment 143941 [details]
committed, r=tonikitoo
Comment 2 Antonio Gomes 2012-05-25 07:43:33 PDT
Comment on attachment 143941 [details]
committed, r=tonikitoo

View in context: https://bugs.webkit.org/attachment.cgi?id=143941&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:901
> +            if (m_mainFrame && m_mainFrame->document() && !(m_mainFrame->document()->viewportArguments() == defaultViewportArguments))

we should really add a != operator to ViewportArguments.
Comment 3 Jacky Jiang 2012-05-25 08:21:49 PDT
(In reply to comment #2)
> (From update of attachment 143941 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143941&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:901
> > +            if (m_mainFrame && m_mainFrame->document() && !(m_mainFrame->document()->viewportArguments() == defaultViewportArguments))
> 
> we should really add a != operator to ViewportArguments.

Opened a bug for this: 87505.
Comment 4 Jacky Jiang 2012-05-25 08:54:40 PDT
Committed r118530: <http://trac.webkit.org/changeset/118530>