Bug 87436 – [chromium] Add a setForceRenderSurface to WebLayer for test/bench purpose

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Labour]

[chromium] Add a setForceRenderSurface to WebLayer for test/bench purpose

[Antoine Labour]

Created attachment 143910 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Dana Jansens]

What about just using opacity != 1 with a child layer?

[Antoine Labour]

So that if we ever change the behavior of that (e.g. if this layer doesn't have content, and we only have a single child, we could bubble the opacity down), this still works. Also, changing opacity also means adding blending which has different perf characteristics.
It's really a "use a render surface, no questions asked" flag.

[Dana Jansens]

I do admit I've wanted this before :)

[James Robinson]

Comment on attachment 143910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143910&action=review

Seems good but I'd drop the uncalled getters, personally.

> Source/Platform/chromium/public/WebLayer.h:130
> +    WEBKIT_EXPORT bool forceRenderSurface() const;

Why expose a getter? The caller should know if they've set this or not and if they care track it (I suspect many won't care).

Compulsively adding getters everywhere makes me feel a bit like writing I'm writing Java.

[Antoine Labour]

Created attachment 143919 [details]
Patch for landing

[Antoine Labour]

(In reply to comment #6)
> (From update of attachment 143910 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143910&action=review
> 
> Seems good but I'd drop the uncalled getters, personally.
> 
> > Source/Platform/chromium/public/WebLayer.h:130
> > +    WEBKIT_EXPORT bool forceRenderSurface() const;
> 
> Why expose a getter? The caller should know if they've set this or not and if they care track it (I suspect many won't care).

I don't care either way. Removed

> Compulsively adding getters everywhere makes me feel a bit like writing I'm writing Java.

Nah, that must be because of the coding style ;)

[WebKit Review Bot]

Comment on attachment 143919 [details]
Patch for landing

Clearing flags on attachment: 143919

Committed r118454: <http://trac.webkit.org/changeset/118454>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.