Bug 87423 - [Chromium] [V8] Layout Test fast/js/string-replace-2.html failing following 11594 => 11648 v8 update
Summary: [Chromium] [V8] Layout Test fast/js/string-replace-2.html failing following 1...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcus Bulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 13:42 PDT by Joshua Bell
Modified: 2012-05-28 09:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-05-28 09:03 PDT, Marcus Bulach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-05-24 13:42:06 PDT 
Layout Test is failing (assertion) on DEBUG Mac/Win/Linux

fast/js/string-replace-2.html

Flakiness dashboard:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fjs%2Fstring-replace-2.html

Assert hit:

STDERR: # Fatal error in /Volumes/data/b/build/slave/webkit-mac-latest-dbg/build/src/v8/tools/gyp/../../src/factory.cc, line 261
STDERR: # CHECK(begin > 0 || end < str->length()) failed
Comment 1 Joshua Bell 2012-05-24 13:50:41 PDT 
Note that the test is currently "expected" to fail, see http://webkit.org/b/80665

But the crashing behavior is obviously new.
Comment 2 Joshua Bell 2012-05-24 13:55:59 PDT 
Added expectation for this in WebKit r118412 but we should either roll back Chromium's V8 or fix this ASAP. Assuming the fix is straightforward and only debug is failing, letting this go for a bit.
Comment 3 Joshua Bell 2012-05-25 15:23:18 PDT 
We can remove this as soon as http://codereview.chromium.org/10443033 lands in Chromium
Comment 4 Marcus Bulach 2012-05-28 09:03:34 PDT 
Created attachment 144375 [details]
Patch
Comment 5 Marcus Bulach 2012-05-28 09:05:53 PDT 
Committed r118687: <http://trac.webkit.org/changeset/118687>
Comment 6 Marcus Bulach 2012-05-28 09:06:59 PDT 
We rolled past http://codereview.chromium.org/10443033, resetting the expectation to TEXT.