RESOLVED FIXED 87420
Move cacheFlush from ExecutableAllocator to Assembler classes 
https://bugs.webkit.org/show_bug.cgi?id=87420
Summary Move cacheFlush from ExecutableAllocator to Assembler classes
Gavin Barraclough
Reported 2012-05-24 13:30:26 PDT
Makes more sense there, & remove a pile of #ifdefs.
Attachments
Fix (17.77 KB, patch)
2012-05-24 13:31 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Style fixes (17.76 KB, patch)
2012-05-24 13:51 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-05-24 13:31:59 PDT
Created attachment 143882 [details] Fix
WebKit Review Bot
Comment 2 2012-05-24 13:34:16 PDT
Attachment 143882 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:1820: Missing space inside { }. [whitespace/braces] [5] Source/JavaScriptCore/assembler/ARMAssembler.h:868: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/assembler/ARMAssembler.h:876: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/assembler/ARMv7Assembler.h:2078: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2012-05-24 13:51:56 PDT
Created attachment 143889 [details] Style fixes
Gavin Barraclough
Comment 4 2012-05-24 14:14:22 PDT
Fixed in r118413
Note You need to log in before you can comment on or make changes to this bug.