Bug 87419 - [BlackBerry] Implement select popup and remove old hook to air popup
Summary: [BlackBerry] Implement select popup and remove old hook to air popup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 13:06 PDT by Crystal Zhang
Modified: 2012-05-24 15:33 PDT (History)
3 users (show)

See Also:


Attachments
patch (26.08 KB, patch)
2012-05-24 13:22 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff
updated patch (26.01 KB, patch)
2012-05-24 14:36 PDT, Crystal Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-05-24 13:06:47 PDT
Implement select popup client and remove the old hook for air popup.
Comment 1 Crystal Zhang 2012-05-24 13:22:25 PDT
Created attachment 143877 [details]
patch
Comment 2 Crystal Zhang 2012-05-24 14:36:40 PDT
Created attachment 143899 [details]
updated patch
Comment 3 Rob Buis 2012-05-24 14:57:43 PDT
Comment on attachment 143899 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143899&action=review

Looks good.

> Source/WebCore/Resources/blackberry/popupControlBlackBerry.css:66
> +}

I think this could have been placed in WebCore/css too, but this works as well.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147
> +        const WTF::Vector<HTMLElement*>& items = m_element->listItems();

You do not need the WTF:: prefix.
Comment 4 WebKit Review Bot 2012-05-24 15:33:31 PDT
Comment on attachment 143899 [details]
updated patch

Clearing flags on attachment: 143899

Committed r118436: <http://trac.webkit.org/changeset/118436>
Comment 5 WebKit Review Bot 2012-05-24 15:33:35 PDT
All reviewed patches have been landed.  Closing bug.