Bug 87412 - [BlackBerry] InputHandler can hold a ref on an object when document is cleared.
Summary: [BlackBerry] InputHandler can hold a ref on an object when document is cleared.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 11:55 PDT by Mike Fenton
Modified: 2012-05-24 15:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2012-05-24 11:58 PDT, Mike Fenton
rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated Patch (2.23 KB, patch)
2012-05-24 13:17 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-05-24 11:55:10 PDT
InputHandler can hold onto a Refptr for an element within a document after the document is cleared.

We need to notify InputHandler of a frame removal to clear state when WebPage::clearDocumentData is called.
Comment 1 Mike Fenton 2012-05-24 11:58:32 PDT
Created attachment 143866 [details]
Patch
Comment 2 Rob Buis 2012-05-24 12:01:39 PDT
Comment on attachment 143866 [details]
Patch

Looks good.
Comment 3 WebKit Review Bot 2012-05-24 12:49:51 PDT
Comment on attachment 143866 [details]
Patch

Rejecting attachment 143866 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 37.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12791290
Comment 4 WebKit Review Bot 2012-05-24 13:13:45 PDT
Comment on attachment 143866 [details]
Patch

Rejecting attachment 143866 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12791296
Comment 5 Mike Fenton 2012-05-24 13:17:40 PDT
Created attachment 143875 [details]
Updated Patch
Comment 6 WebKit Review Bot 2012-05-24 15:38:03 PDT
Comment on attachment 143875 [details]
Updated Patch 

Clearing flags on attachment: 143875

Committed r118438: <http://trac.webkit.org/changeset/118438>
Comment 7 WebKit Review Bot 2012-05-24 15:38:07 PDT
All reviewed patches have been landed.  Closing bug.