Bug 87412 – [BlackBerry] InputHandler can hold a ref on an object when document is cleared.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Fenton]

InputHandler can hold onto a Refptr for an element within a document after the document is cleared.

We need to notify InputHandler of a frame removal to clear state when WebPage::clearDocumentData is called.

[Mike Fenton]

Created attachment 143866 [details]
Patch

[Rob Buis]

Comment on attachment 143866 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 143866 [details]
Patch

Rejecting attachment 143866 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 37.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12791290

[WebKit Review Bot]

Comment on attachment 143866 [details]
Patch

Rejecting attachment 143866 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12791296

[Mike Fenton]

Created attachment 143875 [details]
Updated Patch

[WebKit Review Bot]

Comment on attachment 143875 [details]
Updated Patch 

Clearing flags on attachment: 143875

Committed r118438: <http://trac.webkit.org/changeset/118438>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.